Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build command not picking up env variable override #458

Closed
ismay opened this issue Sep 9, 2020 · 2 comments · Fixed by #459
Closed

Build command not picking up env variable override #458

ismay opened this issue Sep 9, 2020 · 2 comments · Fixed by #459
Labels
released

Comments

@ismay
Copy link
Member

ismay commented Sep 9, 2020

I was expecting the build command to pick up on my override for the DHIS2_BASE_URL (https://github.com/dhis2/app-platform/blob/master/cli/src/commands/build.js#L40). It's been set correctly in my env, and is available for child processes, but the build command is not picking it up:

Screenshot 2020-09-09 at 10 56 46
@ismay
Copy link
Member Author

ismay commented Sep 9, 2020

The OR combined with the ternary on the line linked to above seems to be the culprit: https://dhis2.slack.com/archives/C0BP0RABF/p1599647594150900

@ismay ismay mentioned this issue Sep 9, 2020
Merged
@ismay ismay closed this as completed in #459 Sep 9, 2020
@dhis2-bot
Copy link
Contributor

🎉 This issue has been resolved in version 5.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: base url should be overridden with env var if present dhis2/app-platform
2 participants
@ismay @dhis2-bot