fix(network-shim): use electron instead of chrome for runs

[HendrikThePendric]

The fact that we were using Chrome for cypress runs was a relic of the past that should have been removed. At some point in time, the Network Shim did not have support for 304 requests and to work around this issue I was using Chrome and passing a flag to it to disable the network caching. I had to use Chrome because it wasn't possible to disable the Electron network cache with a flag.

However, I have added support for 304 requests quite a while ago, so we should use Electron instead since that comes with cypress and is therefore guaranteed to be available. I have simply removed the default field, because I think it is best if we use whichever browser cypress uses as default for runs, so I didn't want to set it explicitly in our CLI command.

For reference, here is the part of the code that provides support for 304s:

cli-utils-cypress/packages/cypress-commands/src/setups/enableNetworkShim/captureRequests.js

Lines 92 to 146 in b14a8f2

	/**
	* @description
	* Processes a duplicated request to deal with non-deterministic responses, 304s or true duplicates
	* @param {NetworkShimState} state
	* @param {RequestStub} requestStub
	* @param {Object} newResponseBody The body of a Fetch.Response instance
	* @param {number} responseStatus The response status code
	* @returns {void}
	*/
	function processDuplicatedRequest({
	state,
	requestStub,
	newResponseBody,
	responseStatus,
	}) {
	requestStub.count += 1
	state.duplicates += 1
	const isNotModified = responseStatus === 304
	if (!requestStub.nonDeterministic) {
	// if requestStub.responseBody equals newResponseBody this is a simple
	// duplicated request and we don't take any action
	// And we deal with 304s the same way
	if (requestStub.responseBody !== newResponseBody && !isNotModified) {
	// Switch to nonDeterministic requestStub mode with responseBody array
	state.nonDeterministicResponses += 1
	requestStub.nonDeterministic = true
	requestStub.responseBody = [
	requestStub.responseBody,
	newResponseBody,
	]
	requestStub.responseLookup = [0, 1]
	}
	} else {
	// RequestStub was already nonDeterministic, responseBody is already an array
	const matchingResponseBodyIndex = isNotModified
	? // When isNotModified the response body is empty and the browser is expected
	// to return the last known response, so we do the same.
	requestStub.responseBody.lenght - 1
	: requestStub.responseBody.findIndex(
	responseBody => responseBody === newResponseBody
	)
	if (matchingResponseBodyIndex >= 0) {
	// No need to store the responseBody, we already have it
	requestStub.responseLookup.push(matchingResponseBodyIndex)
	} else {
	// Add a new responseBody
	state.nonDeterministicResponses += 1
	requestStub.responseBody.push(newResponseBody)
	requestStub.responseLookup.push(requestStub.responseBody.length - 1)
	}
	}
	}

[dhis2-bot]

🎉 This PR is included in version 8.0.0-alpha.5 🎉

The release is available on:

• npm package (@alpha dist-tag)
• npm package (@alpha dist-tag)
• npm package (@alpha dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[dhis2-bot]

🎉 This PR is included in version 8.0.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• npm package (@latest dist-tag)
• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀