-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: expose the version as an environment variable in the context #39
Conversation
Very cool that this enables support for multiple instances behind a gateway! See my comment on the companion pr for concerns about tight coupling. One question which may be important - do we want to support arbitrary context paths per cluster, or would it be sufficient to support a singular "cluster" gateway which proxies to multiple "versioned and named" clusters behind it. I.E.
(or something better with nicer commands) Could result in a single gateway pointing at multiple clusters behind-the-scenes, so you could access |
Could you take another look at this as well as https://github.com/amcgee/dhis2-backend/pull/2#issuecomment-490872497? They should be less coupled. |
I'm not exactly sure how this would work in practice, for example, I would still have to put an nginx reverse proxy in front of that "singular gateway" in order to serve the other sites I have on the same server. But maybe |
I pulled out the single port cluster discussion to a separate issue. |
This only exposes the version as an environment property now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
## [1.0.3](v1.0.2...v1.0.3) (2019-05-13) ### Bug Fixes * **cluster:** expose the version as an environment variable in the context ([#39](#39)) ([7e8e8dd](7e8e8dd))
🎉 This PR is included in version 1.0.3 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Relates to: https://github.com/amcgee/dhis2-backend/pull/2No longer coupled to the dhis2-backend PR.