Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing of merge with ublock 1.11.0 #898

Closed
7 tasks done
dhowe opened this issue Mar 5, 2017 · 5 comments
Closed
7 tasks done

Testing of merge with ublock 1.11.0 #898

dhowe opened this issue Mar 5, 2017 · 5 comments
Assignees
Milestone

Comments

@dhowe
Copy link
Owner

dhowe commented Mar 5, 2017

I have fixed traffic.js and some other minor issues and bumped the version. Please continue testing on merged1.11.0-2 branch (v3.3.02)

All Testing done (Chrome, Opera, Firefox)

Issues
All browsers

Firefox
#919 Ask.com Text Ad [on hold]

Other Locales

Other major 3.3 tickets that will influence Adnauseam

@dhowe dhowe added this to the Immediate milestone Mar 5, 2017
@cqx931
Copy link
Collaborator

cqx931 commented Mar 6, 2017

Chrome

Interface

    First-Run

  • Remove and reinstall AdNauseam to trigger this page
  • Test selection of various options (click-ads, block-malware, hide-ads, DNT)
  • Verify that the DNT option is visible only when clicking OR hiding is enabled
  • Test that toggling the DNT option changes both DNT options in Settings
  • Check the links on first-run page
  • Check the version number at left-bottom corner

    Menu

  • Check all buttons and information (including number of Ads and $$ cost, hidden if no ads)
  • Hover over Ad images and check zooming
  • Check there is no text overlap in the menu for text ads
  • Check the uBlock version number(in uBlock menu)
  • Menu shows "AdNauseam is paused on current pages" when AdNauseam is paused, and make sure that the layout is correct.
  • Check that the Adnauseam logo links to homepage

    Vault

  • Verify loading animation, and centering/scaling of Ads on load
  • Zoom in/out using mouse wheel and buttons in top-left corner
  • Check function/layout of Inspector (for both image and text ads)
  • Check correct function of date-filter slider at bottom
  • Check that AdNauseam logo in the bottom-right corner links correctly to homepage
  • Check correct calculation of ad cost (and $$$ updates according to date-filter, hidden if no ads)
  • Test import/export/clear functions
  • Right click on an ad and delete it. Refresh the page and check that it is successfully deleted

    Dashboard

  • Check 2 version numbers in 'About' page (links.html)
  • Check layout of buttons, check-boxes, and links in each tab
  • Test that all (i)nfo buttons lead to correct FAQ pages in each tab
  • On settings tab (options.html) check that when clicking or hiding are disabled, then all of their sub-items are also disabled
  • Test import/export/clear ads functions
  • Test whitelist

    Toolbar Icon

  • Check that the icon in the toolbar is in purple when AdNauseam is active
  • Check that the icon in the toolbar is in grey when AdNauseam is disabled
  • Check that the icon in the toolbar is in green when on DNT pages
  • Icon should animate each time an Ad is clicked (>= v3.1)
  • double check that the badge number is correctly updated

    Notifications

  • Check that disabling hiding, clicking, or blocking on the first-run generates a notification warning at the top of the dashboard (all tabs), menu, and vault page (after first-run is closed or 'ok' is clicked).
  • Check that disabling hiding, clicking, or blocking on the dashboard/options page generates a notification warning at the top of the dashboard(all tabs), menu, and vault page.
  • Check that disabling EasyList/AdNauseam filters on the dashboard/3p-filters page generates a notification warning at the top of the dashboard(all tabs), menu, and vault page.
  • Check that clicking 'reactivate' on a notification warning at the top of the dashboard, menu, or vault pages causes the visual state to change correctly, and the setting in question to be updated correctly.
  • Check that the vault (if open) is updated when notifications change
  • Check that the dashboard (if open) is updated when notifications change
  • Dashboard::settings (options.html) Check that page refreshes correctly when a notification is 'reactivated'
  • Dashboard::3rd-Party (3p-filters.html) Check that page refreshes correctly when a list-notification is 'reactivated'

Ad Hiding/Parsing

  • Test a set of pages, and make sure that ads are being captured and visited
  • ImageAds: visit Facebook/Youtube/Amazon... and verify ads are hidden and appear in menu
  • TextAds: visit Google/Ask/Yahoo/Bing/DuckDuckGo to search for keywords such as "credit card" or "loan"
  • Test Ad-parsing from within dynamically-created iFrames: hidden and collected here
  • Test Ad-parsing from cosmetically-filtered iFrames: hidden but not collected (without cosmetic filters for any contained elements) here
  • Test that no Ads are collected in incognito/private-browsing windows:

DoNotTrack (DNT)

DNT: Go to a DNT page (Ex: duckduckgo.com) and check the following items:

    Headers/Cookies

    To check ad visits headers, click on request in browser's network panel, select 'Headers'
    (For a more detailed network logging, you can check Chrome Net-Internals of the tools listed below.)

  • DNT-header is being sent correctly for ALL requests (including Ad visits) if either disableClickingForDNT and disableHidingForDNT are enabled (and vice versa)
  • DNT Cookie handling (v3.1 and later)

    Hiding/Clicking

  • Ads are visible when domain is 1st-party if disableHidingForDNT is checked
  • Requests are not blocked when domain is 1st-party iff disableHidingForDNT is checked
  • Requests are not blocked when domain is 3rd-party iff disableHidingForDNT is checked(hrere)
  • No clicking when ad domain is on list iff disableClickingForDNT is checked (especially for 3rd-party)
  • If both DNT options are disabled, then hiding, blocking, visiting occur again as usual(both first pary and 3-rd party)

    Interface

  • DNT list at top of whitelist.html is checked when either DNT option is checked, otherwise unchecked
  • Check that changing the two DNT settings will triggger DNT notifications with corresponding messages to the menu
  • Check the layout of each DNT notification("?" should be in the middle, 'settings' button appears on hover)

    Test Page for 3rd-party DNT


Cookies

  • Test that no cookies are accepted from adn-ALLOWed requests: Test Case
    • Make sure ‘Activate debugging mode’ is set to true to view log info in the console
    • Visit sites where one or more 3rd-party requests are adn-ALLOWed and note their domains
  • Verify that no cookies are accepted from these domains: first by checking cookies before/after in the browser, then verify using one of the tools listed below (look for 'set-cookies' in response Header)

Ad Visits

To check headers for ad visits, please go to developer tools of the browser -> Network -> click on a request -> select 'Headers'. You can also click on 'XHR' type to filter the requests.
(For a more detailed network logging, you can check Chrome Net-Internals of the tools listed below.)

  • Test that the correct 'referer' header is sent on Ad visits depending on the setting (ad.pageUrl when disabled, or none when enabled)
  • Test that the correct 'user-agent' header is sent on Ad visits depending on the setting (the usual user-agent when disabled, or default when enabled)
  • Test that outgoing cookies are sent on Ad visits depending on the setting (the usual cookies when disabled, or none when enabled)
  • Test that incoming cookies are not allowed from responses to Ad visits, by checking cookies before/after
    (if only Channel ID cookies are allowed, it is ok for now) TestCase
  • Please notice that, sometimes there is a “CAUTION: provisional headers are shown” message when you check headers in the console. If you see this message, the headers shown are not reliable. Therefore it should not be considered as a reference when checking the headers during test release/ debugging. Check other requests or use Chrome Net-Internals instead.

Check Ad Blockers

  • Install uBlock

  • Remove and reinstall AdNauseam to trigger the first-run page

  • check if there is a warning about other ad blockers on first-run page,menu and vault

  • click 'disable' button on the warning message, it should lead to the extension page

  • disable uBlock and check whether the message is gone in vault and menu.(If the page was opened, it need to be refreshed)

    Test this for only AdBlock Plus installed, only uBlock/uBlock Origin, and both installed


Check Blocking

  • Check that the request from the following test page is blocked by adnauseam by using the uBlock logger
    here

Check Element-picker Tool

  • Go to some web page with a visible ad, then right-click, select 'Block element', create a rule to hide the element

Test Update

  • Test Manual Update by clicking "Update Now" in settings page
    1. Change the local uAsset and run tools/update-ublock0.sh to generate a new checksum
    2. Rebuild AdNauseam
    3. Click "Update Now" in Settings Page and check
    • A request has been made to fetch adnauseam.txt from github
    • The total rules of adnauseam has been updated
    • The rules are functioning when test on webpage.
  • Test Auto Update
    Check the same thing above with a different procedure:
  1. Go to assets.js and change two variables in assetUpdater:
    autoUpdateDaemonTimerPeriod = 2 * 1000; // 2 seconds
    updateCycleFirstPeriod = 30 * 1000; // 30 seconds
  2. Rebuild AdNauseam
  3. Delete and reinstall AdNauseam
  4. Activate debugging mode and open the background.html page to observe the console
  5. Wait till the autoUpdate triggers and check whether there is any error message in the console
  6. Check the same things as above

@cqx931
Copy link
Collaborator

cqx931 commented Mar 9, 2017

Opera

Interface

    First-Run

  • Remove and reinstall AdNauseam to trigger this page
  • Test selection of various options (click-ads, block-malware, hide-ads, DNT)
  • Verify that the DNT option is visible only when clicking OR hiding is enabled
  • Test that toggling the DNT option changes both DNT options in Settings
  • Check the links on first-run page
  • Check the version number at left-bottom corner

    Menu

  • Check all buttons and information (including number of Ads and $$ cost, hidden if no ads)
  • Hover over Ad images and check zooming
  • Check there is no text overlap in the menu for text ads
  • Check the uBlock version number(in uBlock menu)
  • Menu shows "AdNauseam is paused on current pages" when AdNauseam is paused, and make sure that the layout is correct.
  • Check that the Adnauseam logo links to homepage

    Vault

  • Verify loading animation, and centering/scaling of Ads on load
  • Zoom in/out using mouse wheel and buttons in top-left corner
  • Check function/layout of Inspector (for both image and text ads)
  • Check correct function of date-filter slider at bottom
  • Check that AdNauseam logo in the bottom-right corner links correctly to homepage
  • Check correct calculation of ad cost (and $$$ updates according to date-filter, hidden if no ads)
  • Test import/export/clear functions
  • Right click on an ad and delete it. Refresh the page and check that it is successfully deleted

    Dashboard

  • Check 2 version numbers in 'About' page (links.html)
  • Check layout of buttons, check-boxes, and links in each tab
  • Test that all (i)nfo buttons lead to correct FAQ pages in each tab
  • On settings tab (options.html) check that when clicking or hiding are disabled, then all of their sub-items are also disabled
  • Test import/export/clear ads functions
  • Test whitelist

    Toolbar Icon

  • Check that the icon in the toolbar is in purple when AdNauseam is active
  • Check that the icon in the toolbar is in grey when AdNauseam is disabled
  • Check that the icon in the toolbar is in green when on DNT pages
  • Icon should animate each time an Ad is clicked (>= v3.1)
  • double check that the badge number is correctly updated

    Notifications

  • Check that disabling hiding, clicking, or blocking on the first-run generates a notification warning at the top of the dashboard (all tabs), menu, and vault page (after first-run is closed or 'ok' is clicked).
  • Check that disabling hiding, clicking, or blocking on the dashboard/options page generates a notification warning at the top of the dashboard(all tabs), menu, and vault page.
  • Check that disabling EasyList/AdNauseam filters on the dashboard/3p-filters page generates a notification warning at the top of the dashboard(all tabs), menu, and vault page.
  • Check that clicking 'reactivate' on a notification warning at the top of the dashboard, menu, or vault pages causes the visual state to change correctly, and the setting in question to be updated correctly.
  • Check that the vault (if open) is updated when notifications change
  • Check that the dashboard (if open) is updated when notifications change
  • Dashboard::settings (options.html) Check that page refreshes correctly when a notification is 'reactivated'
  • Dashboard::3rd-Party (3p-filters.html) Check that page refreshes correctly when a list-notification is 'reactivated'

Ad Hiding/Parsing

  • Test a set of pages, and make sure that ads are being captured and visited
  • ImageAds: visit Facebook/Youtube/Amazon... and verify ads are hidden and appear in menu
  • TextAds: visit Google/Ask/Yahoo/Bing/DuckDuckGo to search for keywords such as "credit card" or "loan"
  • Test Ad-parsing from within dynamically-created iFrames: hidden and collected here
  • Test Ad-parsing from cosmetically-filtered iFrames: hidden but not collected (without cosmetic filters for any contained elements) here
  • Test that no Ads are collected in incognito/private-browsing windows:

DoNotTrack (DNT)

DNT: Go to a DNT page (Ex: duckduckgo.com) and check the following items:

    Headers/Cookies

    To check ad visits headers, click on request in browser's network panel, select 'Headers'
    (For a more detailed network logging, you can check Chrome Net-Internals of the tools listed below.)

  • DNT-header is being sent correctly for ALL requests (including Ad visits) if either disableClickingForDNT and disableHidingForDNT are enabled (and vice versa)
  • DNT Cookie handling (v3.1 and later)

    Hiding/Clicking

  • Ads are visible when domain is 1st-party if disableHidingForDNT is checked
  • Requests are not blocked when domain is 1st-party iff disableHidingForDNT is checked
  • Requests are not blocked when domain is 3rd-party iff disableHidingForDNT is checked(hrere)
  • No clicking when ad domain is on list iff disableClickingForDNT is checked (especially for 3rd-party)
  • If both DNT options are disabled, then hiding, blocking, visiting occur again as usual(both first pary and 3-rd party)

    Interface

  • DNT list at top of whitelist.html is checked when either DNT option is checked, otherwise unchecked
  • Check that changing the two DNT settings will triggger DNT notifications with corresponding messages to the menu
  • Check the layout of each DNT notification("?" should be in the middle, 'settings' button appears on hover)

    Test Page for 3rd-party DNT


Cookies

  • Test that no cookies are accepted from adn-ALLOWed requests: Test Case
    • Make sure ‘Activate debugging mode’ is set to true to view log info in the console
    • Visit sites where one or more 3rd-party requests are adn-ALLOWed and note their domains
  • Verify that no cookies are accepted from these domains: first by checking cookies before/after in the browser, then verify using one of the tools listed below (look for 'set-cookies' in response Header)

Ad Visits

To check headers for ad visits, please go to developer tools of the browser -> Network -> click on a request -> select 'Headers'. You can also click on 'XHR' type to filter the requests.
(For a more detailed network logging, you can check Chrome Net-Internals of the tools listed below.)

  • Test that the correct 'referer' header is sent on Ad visits depending on the setting (ad.pageUrl when disabled, or none when enabled)
  • Test that the correct 'user-agent' header is sent on Ad visits depending on the setting (the usual user-agent when disabled, or default when enabled)
  • Test that outgoing cookies are sent on Ad visits depending on the setting (the usual cookies when disabled, or none when enabled)
  • Test that incoming cookies are not allowed from responses to Ad visits, by checking cookies before/after
    (if only Channel ID cookies are allowed, it is ok for now) TestCase
  • Please notice that, sometimes there is a “CAUTION: provisional headers are shown” message when you check headers in the console. If you see this message, the headers shown are not reliable. Therefore it should not be considered as a reference when checking the headers during test release/ debugging. Check other requests or use Chrome Net-Internals instead.

Check Ad Blockers

  • Install uBlock

  • Remove and reinstall AdNauseam to trigger the first-run page

  • check if there is a warning about other ad blockers on first-run page,menu and vault

  • click 'disable' button on the warning message, it should lead to the extension page

  • disable uBlock and check whether the message is gone in vault and menu.(If the page was opened, it need to be refreshed)

    Test this for only AdBlock Plus installed, only uBlock/uBlock Origin, and both installed


Check Blocking

  • Check that the request from the following test page is blocked by adnauseam by using the uBlock logger
    here

Check Element-picker Tool

  • Go to some web page with a visible ad, then right-click, select 'Block element', create a rule to hide the element

Test Update

  • Test Manual Update by clicking "Update Now" in settings page
    1. Change the local uAsset and run tools/update-ublock0.sh to generate a new checksum
    2. Rebuild AdNauseam
    3. Click "Update Now" in Settings Page and check
    • All out-dated filters are updated (background.html console)
    • The total rules of adnauseam has been updated
    • The rules are functioning when test on webpage.
  • Test Auto Update
    Check the same thing above with a different procedure:

@cqx931
Copy link
Collaborator

cqx931 commented Mar 9, 2017

Firefox

Interface

    First-Run

  • Remove and reinstall AdNauseam to trigger this page
  • Test selection of various options (click-ads, block-malware, hide-ads, DNT)
  • Verify that the DNT option is visible only when clicking OR hiding is enabled
  • Test that toggling the DNT option changes both DNT options in Settings
  • Check the links on first-run page
  • Check the version number at left-bottom corner

    Menu

  • Check all buttons and information (including number of Ads and $$ cost, hidden if no ads)
  • Hover over Ad images and check zooming
  • Check there is no text overlap in the menu for text ads
  • Check AdNauseam version number(in uBlock menu)
  • Menu shows "AdNauseam is paused on current pages" when AdNauseam is paused, and make sure that the layout is correct.
  • Check that the Adnauseam logo links to homepage

    Vault

  • Verify loading animation, and centering/scaling of Ads on load
  • Zoom in/out using mouse wheel and buttons in top-left corner
  • Check function/layout of Inspector (for both image and text ads)
  • Check correct function of date-filter slider at bottom
  • Check that AdNauseam logo in the bottom-right corner links correctly to homepage
  • Check correct calculation of ad cost (and $$$ updates according to date-filter, hidden if no ads)
  • Test import/export/clear functions
  • Right click on an ad and delete it. Refresh the page and check that it is successfully deleted

    Dashboard

  • Check 2 version numbers in 'About' page (links.html)
  • Check layout of buttons, check-boxes, and links in each tab
  • Test that all (i)nfo buttons lead to correct FAQ pages in each tab
  • On settings tab (options.html) check that when clicking or hiding are disabled, then all of their sub-items are also disabled
  • Test import/export/clear ads functions
  • Test whitelist

    Toolbar Icon

  • Check that the icon in the toolbar is in purple when AdNauseam is active
  • Check that the icon in the toolbar is in grey when AdNauseam is disabled
  • Check that the icon in the toolbar is in green when on DNT pages
  • Icon should animate each time an Ad is clicked (>= v3.1)
  • double check that the badge number is correctly updated

    Notifications

  • Check that disabling hiding, clicking, or blocking on the first-run generates a notification warning at the top of the dashboard (all tabs), menu, and vault page (after first-run is closed or 'ok' is clicked).
  • Check that disabling hiding, clicking, or blocking on the dashboard/options page generates a notification warning at the top of the dashboard(all tabs), menu, and vault page.
  • Check that disabling EasyList/AdNauseam filters on the dashboard/3p-filters page generates a notification warning at the top of the dashboard(all tabs), menu, and vault page.
  • Check that clicking 'reactivate' on a notification warning at the top of the dashboard, menu, or vault pages causes the visual state to change correctly, and the setting in question to be updated correctly.
  • Check that the vault (if open) is updated when notifications change
  • Check that the dashboard (if open) is updated when notifications change
  • Dashboard::settings (options.html) Check that page refreshes correctly when a notification is 'reactivated'
  • Dashboard::3rd-Party (3p-filters.html) Check that page refreshes correctly when a list-notification is 'reactivated'

Ad Hiding/Parsing

  • Test a set of pages, and make sure that ads are being captured and visited
  • ImageAds: visit Facebook/Youtube/Amazon... and verify ads are hidden and appear in menu
  • TextAds: visit Google/Ask/Yahoo/Bing/DuckDuckGo to search for keywords such as "credit card" or "loan"
  • Test Ad-parsing from within dynamically-created iFrames: hidden and collected here
  • Test Ad-parsing from cosmetically-filtered iFrames: hidden but not collected (without cosmetic filters for any contained elements) here
  • Test that no Ads are collected in incognito/private-browsing windows:

DoNotTrack (DNT)

DNT: Go to a DNT page (Ex: duckduckgo.com) and check the following items:

    Headers/Cookies

    To check ad visits headers, click on request in browser's network panel, select 'Headers'
    (For a more detailed network logging, you can check Chrome Net-Internals of the tools listed below.)

  • DNT-header is being sent correctly for ALL requests (including Ad visits) if either disableClickingForDNT and disableHidingForDNT are enabled (and vice versa)
  • DNT Cookie handling (v3.1 and later)

    Hiding/Clicking

  • Ads are visible when domain is 1st-party if disableHidingForDNT is checked
  • Requests are not blocked when domain is 1st-party iff disableHidingForDNT is checked
  • Requests are not blocked when domain is 3rd-party iff disableHidingForDNT is checked(hrere)
  • No clicking when ad domain is on list iff disableClickingForDNT is checked (especially for 3rd-party)
  • If both DNT options are disabled, then hiding, blocking, visiting occur again as usual(both first pary and 3-rd party)

    Interface

  • DNT list at top of whitelist.html is checked when either DNT option is checked, otherwise unchecked
  • Check that changing the two DNT settings will triggger DNT notifications with corresponding messages to the menu
  • Check the layout of each DNT notification("?" should be in the middle, 'settings' button appears on hover)

    Test Page for 3rd-party DNT


Cookies

  • Test that no cookies are accepted from adn-ALLOWed requests: Test Case
    • Make sure ‘Activate debugging mode’ is set to true to view log info in the console
    • Visit sites where one or more 3rd-party requests are adn-ALLOWed and note their domains
  • Verify that no cookies are accepted from these domains: first by checking cookies before/after in the browser, then verify using one of the tools listed below (look for 'set-cookies' in response Header)

Ad Visits

To check headers for ad visits, please go to developer tools of the browser -> Network -> click on a request -> select 'Headers'. You can also click on 'XHR' type to filter the requests.
(For a more detailed network logging, you can check Chrome Net-Internals of the tools listed below.)

  • Test that the correct 'referer' header is sent on Ad visits depending on the setting (ad.pageUrl when disabled, or none when enabled)
  • Test that the correct 'user-agent' header is sent on Ad visits depending on the setting (the usual user-agent when disabled, or default when enabled)
  • Test that outgoing cookies are sent on Ad visits depending on the setting (the usual cookies when disabled, or none when enabled)
  • Test that incoming cookies are not allowed from responses to Ad visits, by checking cookies before/after
    (if only Channel ID cookies are allowed, it is ok for now) TestCase
  • Please notice that, sometimes there is a “CAUTION: provisional headers are shown” message when you check headers in the console. If you see this message, the headers shown are not reliable. Therefore it should not be considered as a reference when checking the headers during test release/ debugging. Check other requests or use Chrome Net-Internals instead.

Check Ad Blockers

  • Install uBlock Origin

  • Remove and reinstall AdNauseam to trigger the first-run page

  • check if there is a warning about other ad blockers on first-run page,menu and vault

  • click 'disable' button on the warning message, it should lead to the extension page

  • disable uBlock and check whether the message is gone in vault and menu.(If the page was opened, it need to be refreshed)

    _Test this for Adblock Plus/AdBlock/uBlock as well


Check Blocking

  • Check that the request from the following test page is blocked by adnauseam by using the uBlock logger
    here

Check Element-picker Tool

  • Go to some web page with a visible ad, then right-click, select 'Block element', create a rule to hide the element

Test Update

  • Test Manual Update by clicking "Update Now" in settings page
    1. Change the local uAsset and run tools/update-ublock0.sh to generate a new checksum
    2. Rebuild AdNauseam
    3. Click "Update Now" in Settings Page and check
    • All out-dated filters are updated (background.html console)
    • The total rules of adnauseam has been updated
    • The rules are functioning when test on webpage.
  • Test Auto Update
    Check the same thing above with a different procedure:
  1. Go to start.js and change this line : "µb.scheduleAssetUpdater(µb.userSettings.autoUpdate ? 7 * 60 * 1000 : 0);" to "µb.scheduleAssetUpdater(µb.userSettings.autoUpdate ? 10 * 1000 : 0);"
  2. Go to background.js and change autoUpdateAssetFetchPeriod to 1
  3. Rebuild AdNauseam
  4. Delete and reinstall AdNauseam
  5. Activate debugging mode and open the background.html page to check the logging message in the console
  6. Wait till the autoUpdate triggers and check whether there is any error message in the console
  7. Check the same things as above

@dhowe
Copy link
Owner Author

dhowe commented Mar 13, 2017

@cqx931 status on the tasks at top ?

@cqx931
Copy link
Collaborator

cqx931 commented Mar 16, 2017

Tickets mentioned above are all solved by now. This can be closed

@cqx931 cqx931 closed this as completed Mar 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants