Allow finding dials_regression from environment #1674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1674 +/- ##
=======================================
Coverage 66.65% 66.65%
=======================================
Files 615 615
Lines 68873 68870 -3
Branches 9571 9572 +1
=======================================
Hits 45905 45905
+ Misses 21043 21040 -3
Partials 1925 1925 |
|
build failure unrelated and fixed on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As an alternative to copying into multiple places, or softlinking manually, it makes sense to follow the example of dials-data and let the be environment-configured so that we never need to think of it again, once it is setup.
Same change as cctbx/dxtbx#350, but in dials, since this logic is duplicated for package-independence.