Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPI improvements from EuXFEL experiment #1687

Merged
merged 2 commits into from
May 13, 2021
Merged

MPI improvements from EuXFEL experiment #1687

merged 2 commits into from
May 13, 2021

Conversation

phyy-nx
Copy link
Member

@phyy-nx phyy-nx commented May 5, 2021

  • Add parameter output_debug_logs = True. Controls whether to write debugging information for every image. These are the .txt files in the debug folder that help with diagnostics, but when running on 7K cores, they stress the file system too much.
  • Move instantiation of the Processor object. Before it was in the if/else of the MPI client/server code. Now, each process creates a Processor object before client/server, then calls finalize on the object after client/server. This allows downstream applications (like the XFEL GUI) to put synchronization code in the __init__function of the Processor.

- Add parameter output_debug_logs = True. Controls whether to write debugging information for every image.  These are the .txt files in the debug folder that help with diagnostics, but when running on 7K cores, they stress the file system too much.
- Move instantiation of the Processor object.  Before it was in the if/else of the MPI client/server code.  Now, each process creates a Processor object before client/server, then calls finalize on the object after client/server.  This allows downstream applications (like the XFEL GUI) to put synchronization code in the __init__function of the Processor.
@phyy-nx phyy-nx merged commit 8967c3f into main May 13, 2021
@phyy-nx phyy-nx deleted the dsp_mpi_euxfel branch May 13, 2021 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants