Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Critical dependency: the request of a dependency is an expression (jspdf) #983

Closed
Robert-OP opened this issue Aug 22, 2020 · 1 comment
Closed

Critical dependency: the request of a dependency is an expression (jspdf) #983

Robert-OP opened this issue Aug 22, 2020 · 1 comment

Comments

@Robert-OP
Copy link

First of all
Great work with this library guys, well done! 🥇

Describe the bug
It is not that critical, but whilst using react-pdf library (v1.6.10), I found a warning that is related to jspdf dependency.

To Reproduce
Steps to reproduce the behavior would require to add the library to the project.

Screenshots
Browser console warning
image

Desktop (please complete the following information):

  • OS: Windows
  • Browser: Chrome
  • React-pdf version: v1.6.10

May be helpful
I found that the latest version of jspdf introduced this and also found in this issue parallax/jsPDF#2846
@diegomura
Copy link
Owner

I think this belong to https://github.com/wojtekmaj/react-pdf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@diegomura @Robert-OP