Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduplicate translation.json using succinct keys #11

Open
pdobacz opened this issue Sep 28, 2022 · 6 comments
Open

Deduplicate translation.json using succinct keys #11

pdobacz opened this issue Sep 28, 2022 · 6 comments

Comments

@pdobacz
Copy link
Collaborator

pdobacz commented Sep 28, 2022

See #7 (comment)

(when done, open a low-priority issue in desktop to do the same, for consistency)

@pdobacz pdobacz added the low priority Low priority label Sep 28, 2022
@cristianberneanu cristianberneanu removed the low priority Low priority label Sep 28, 2022
@pdobacz
Copy link
Collaborator Author

pdobacz commented Sep 29, 2022

I think Edon started a discussion to keep the keys as they are here. The duplication doesn't bother me personally, and I think Edon makes a point there. Do we want to keep this issue?

@pdobacz pdobacz mentioned this issue Sep 29, 2022
@edongashi
Copy link
Member

I think natural keys have a few benefits:

  • We don't need to add anything to the json file while developing because of fallback. The fallback is the key, which is the English version of the string.
  • You can see the final text directly from source code.
  • It will be easier to review and translate to German because the file will be of shape "English": "German"

@cristianberneanu
Copy link
Contributor

I won't insist on this too much, especially if you are both against the change, but I find the approach pretty impractical.

The text appears in code, which adds noise and messes up the layout, it also appears twice in the English translation file, and once more for each additional language we support. There are a lot of places to update when one changes a displayed string.

At the very least, we should get rid of the English translation file, as it is 100% redundant.

@edongashi
Copy link
Member

if you are both against the change

I'm not against changing, I agree that it's very noisy currently. Better to do it now in early stages than later.

@pdobacz
Copy link
Collaborator Author

pdobacz commented Sep 29, 2022

Oh, maybe I'm confused then. I thought the deduplication here is about not having the natural language keys and always referring to the translation.json for the actual contents.

If so, I'm slightly against changing, but not a strong opinion. Dropping the English translation would be great though

@pdobacz
Copy link
Collaborator Author

pdobacz commented Oct 18, 2022

Do we have a decision on this one? Any new arguments, after i18n caused problems in the webpage translation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants