-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deduplicate translation.json using succinct keys #11
Comments
I think Edon started a discussion to keep the keys as they are here. The duplication doesn't bother me personally, and I think Edon makes a point there. Do we want to keep this issue? |
I think natural keys have a few benefits:
|
I won't insist on this too much, especially if you are both against the change, but I find the approach pretty impractical. The text appears in code, which adds noise and messes up the layout, it also appears twice in the English translation file, and once more for each additional language we support. There are a lot of places to update when one changes a displayed string. At the very least, we should get rid of the English translation file, as it is 100% redundant. |
I'm not against changing, I agree that it's very noisy currently. Better to do it now in early stages than later. |
Oh, maybe I'm confused then. I thought the deduplication here is about not having the natural language keys and always referring to the If so, I'm slightly against changing, but not a strong opinion. Dropping the English translation would be great though |
Do we have a decision on this one? Any new arguments, after i18n caused problems in the webpage translation? |
See #7 (comment)
(when done, open a low-priority issue in
desktop
to do the same, for consistency)The text was updated successfully, but these errors were encountered: