-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broken in Microsoft Edge #13
Comments
Thanks for opening an issue for this. This was a known limitation when I first wrote this and still needs a fix, ideally by someone with Windows and Microsoft Edge :) |
I ended up implementing my own version of the library because we needed a bit more flexibility. |
Any chance you could share your fork, or create a pull request, I can't use this library if it doesn't support IE :'( Also, given the state of slider-thumb support, I think @Lknechtli's approach might be a better way to go: |
@chriszrc |
I tried to fix this, but Edge doesn't seem to allow this natively without many JS side workarounds. Setting an absolute position on the range slider simply breaks the events on the thumb in Edge. It doesn't respond any longer. Positioning it with a container element helps with this, but that has two side-effects:
|
I'm using the plugin on an internal project, and it works well for us (Edge, Chrome, Safari and FF) with the following css changes : .leaflet-sbs-range { .leaflet-sbs { |
@gspettel That doesn't work for me in neither Edge nor Chrome. It doesn't even show the range button any longer in Chrome. Do you have a hosted working example somewhere? Or the working code on GitHub? I must have missed something or its just working in some cases... |
Looks like mapbox has a nice one now: https://github.com/mapbox/mapbox-gl-compare Officially supported too - https://www.mapbox.com/mapbox-gl-js/example/mapbox-gl-compare/ |
I've been experimenting with the mapbox slider on side projects for a bit. That slider has performance issues, because it requires rendering two whole maps at the same time, and hiding parts of each of them. Performance issues when rotating the map while the view angle is not straight down are the most apparent - the two sides of the map will frequently get out of sync while rendering and it's very clear that one side of the map is following the other. The performance issues mostly happen on my computer when you've zoomed in to about the state level. It also has some other odd issues - when zooming using a shift+click+drag, the box that is drawn will not carry across the two halves of the map. Any interactions on mouse click + drag need to be reported to both sides and duplicated on both maps in order for it to look seamless, and the plugin doesn't do a very good job at it. Basemap tiles are requested twice, even if they are the same on both maps, etc. I stuck up a simple app (wip) which can compare two TMS layer urls using the slider here, you can see for yourself. https://lknechtli.github.io/elm-map-compare/ |
In Microsoft edge, the section of the slider that you grab is not visible / grabbable.
The text was updated successfully, but these errors were encountered: