Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO/FIXME Count 6 #39

Open
6 tasks
mattcollier opened this issue Jun 16, 2020 · 0 comments
Open
6 tasks

TODO/FIXME Count 6 #39

mattcollier opened this issue Jun 16, 2020 · 0 comments

Comments

@mattcollier
Copy link
Contributor

  • FIXME: consider not running this automatically (breaking change)
    Commit: (918b404) Simplify API; use promises.
    File: lib/index.js:389
    Dave Longley commented 2 years ago

  • TODO: which identity? it is possible to authenticate as multiple, so
    Commit: (918b404) Simplify API; use promises.
    File: lib/index.js:251
    Dave Longley commented 2 years ago

  • TODO: may want to allow users to authenticate as multiple accounts when
    Commit: (918b404) Simplify API; use promises.
    File: lib/index.js:209
    Dave Longley commented 2 years ago

  • FIXME: req.isAuthenticated is not technically granular enough
    Commit: (918b404) Simplify API; use promises.
    File: lib/index.js:96
    Dave Longley commented 2 years ago

  • TODO: potentially refactor to avoid this auto-check in the future,
    Commit: (918b404) Simplify API; use promises.
    File: lib/index.js:94
    Dave Longley commented 2 years ago

  • TODO: add an option to allow controlling permittedCorsMethods for
    Commit: (918b404) Simplify API; use promises.
    File: lib/index.js:82
    Dave Longley commented 2 years ago

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant