Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link list is loading very slow in regions with a lot of content #2539

Closed
timobrembeck opened this issue Nov 7, 2023 · 3 comments · Fixed by #2832
Closed

Link list is loading very slow in regions with a lot of content #2539

timobrembeck opened this issue Nov 7, 2023 · 3 comments · Fixed by #2832
Assignees
Labels
bug Something isn't working effort: high Big change, which requires >12h prio: medium Should be scheduled in the forseeable future.
Milestone

Comments

@timobrembeck
Copy link
Member

Describe the Bug

Steps to Reproduce

  1. Go to https://cms-test.integreat-app.de/muenchen/analytics/linkcheck/invalid/
  2. Wait for 20s
  3. See page

Expected Behavior

The linkcheck list should load in a couple of seconds (maybe a maximum of 5s for really large regions?)

Actual Behavior

It's considerably slower

Additional Information

After this is fixed, the linkcheck row can be shown again in the dashboard:

Revert 1f9be58

@timobrembeck timobrembeck added bug Something isn't working prio: medium Should be scheduled in the forseeable future. effort: high Big change, which requires >12h labels Nov 7, 2023
@timobrembeck timobrembeck added this to the 24Q1 milestone Nov 7, 2023
@david-venhoff
Copy link
Member

david-venhoff commented Jan 8, 2024

I tried to reproduce this by creating one page with ~750 different valid urls and another page with ~750 different invalid urls. Then I made 32 copies of each page.

However, the relevant code of the dashboard ran in about 300-500 ms for me. I also noticed that the example link (https://cms-test.integreat-app.de/muenchen/analytics/linkcheck/invalid/) loads in about 7 seconds, which seems a lot better than 20 seconds. Could it be that this issue has already been fixed?

Otherwise I could imagine that the problem only happens when there are lots of pages that contain different links, but that is hard to test locally.

Apart from that, one simple way to improve the performance for the dashboard would be to specify prefetch_content_objects=False in the call to filter_urls. This roughly halves the time required on my pc.

@david-venhoff david-venhoff added the blocked Blocked by external dependency label Feb 13, 2024
@david-venhoff
Copy link
Member

david-venhoff commented Feb 13, 2024

Adding the blocked label because it is hard to reproduce locally without #2516

@osmers
Copy link

osmers commented Jun 4, 2024

Is this maybe an infrastructure topic/problem as well?

@david-venhoff david-venhoff removed the blocked Blocked by external dependency label Jun 5, 2024
@david-venhoff david-venhoff self-assigned this Jun 7, 2024
@MizukiTemma MizukiTemma modified the milestones: 24Q2, 24Q3 Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working effort: high Big change, which requires >12h prio: medium Should be scheduled in the forseeable future.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants