Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkbox to auto update link always selected #3001

Closed
PeterNerlich opened this issue Aug 15, 2024 · 0 comments · Fixed by #3002
Closed

Checkbox to auto update link always selected #3001

PeterNerlich opened this issue Aug 15, 2024 · 0 comments · Fixed by #3002
Assignees
Labels
bug Something isn't working effort: low Should be doable in <4h javascript Pull requests that update Javascript code
Milestone

Comments

@PeterNerlich
Copy link
Collaborator

Describe the Bug

Our current implementation seems to violate the following paragraph from the original outline in #1878:

When inserting a link, we already have a dialog for selecting an internal content to link to. This dialog needs something like a check box "automatically update link description". This check box should be checked when having no text selected. When having a text selected, the checkbox should be unchecked.

Instead, the checkbox is also checked when text is selected.

Steps to Reproduce

  1. Go to any page
  2. Select a word that is not yet linked
  3. Create a link
  4. The Link dialog pops up

Expected Behavior

As existing text is selected, the checkbox should not be checked and the created link should retain it as link text.

Actual Behavior

The checkbox is selected, and if a target is selected and the dialog is submitted in this state, the link retains the originally selected text. However, when submitting the content to the server, the link is immediately updated, as the link text does not reflect the title of the linked page.

Additional Information

To reduce confusion along with fixing the bug, the following changes are proposed:

  1. when text is selected, the checkbox should be unchecked
  2. when the checkbox is checked on closing the dialog, the link text should be updated right away
  3. the checkbox description could be more explicit
  4. nice to have: when the checkbox is checked, the text field could be disabled and already show the title of the selected content
@PeterNerlich PeterNerlich added bug Something isn't working effort: low Should be doable in <4h javascript Pull requests that update Javascript code labels Aug 15, 2024
@PeterNerlich PeterNerlich added this to the 24Q3 milestone Aug 15, 2024
@PeterNerlich PeterNerlich self-assigned this Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working effort: low Should be doable in <4h javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant