Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image size as direct argument #58

Closed
ronilaukkarinen opened this issue Oct 11, 2022 · 1 comment · Fixed by #73
Closed

Image size as direct argument #58

ronilaukkarinen opened this issue Oct 11, 2022 · 1 comment · Fixed by #73
Assignees
@timiwahalahti
Labels
[Priority] Low [Status] Hold [Status] Needs decision [Type] Enhancement

Comments

@ronilaukkarinen
Copy link
Member

Instead of

<?php native_lazyload_tag( $image_id, [ 'sizes' => [ 'big' => 'thumbnail' ] ] ) ?>

We could just

<?php native_lazyload_tag( $image_id, 'thumbnail' ) ?>
@timiwahalahti
Copy link
Contributor

Related to the bigger question about image lazyload tags, that might be moved to the theme at some point. Going to mark as wontfix for now.

@raikasdev raikasdev mentioned this issue Dec 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timiwahalahti timiwahalahti

Labels
[Priority] Low [Status] Hold [Status] Needs decision [Type] Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow shorthand for lazyloading images digitoimistodude/air-helper
2 participants
@timiwahalahti @ronilaukkarinen