Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parses and stores search_on_clear from suite #1397

Merged
merged 4 commits into from
Jan 22, 2024
Merged

Conversation

Jtang-1
Copy link
Contributor

@Jtang-1 Jtang-1 commented Jan 16, 2024

Product Description

See description in HQ PR

Technical Summary

Jira Ticket
Formplayer PR
HQ PR

Safety Assurance

Safety story

tested locally

Automated test coverage

adds test that instance contains the search_on_clear value as defined in the suite

QA Plan

no QA

Special deploy instructions

  • This PR can be deployed after merge with no further considerations.

Rollback instructions

  • This PR can be reverted after deploy with no further considerations.

Review

  • The set of people pinged as reviewers is appropriate for the level of risk of the change.

Duplicate PR

Automatically duplicate this PR as defined in contributing.md.

@Jtang-1 Jtang-1 marked this pull request as ready for review January 16, 2024 22:52
@Jtang-1 Jtang-1 merged commit ed8413c into formplayer Jan 22, 2024
2 checks passed
@Jtang-1 Jtang-1 deleted the jt/clear-on-search branch January 22, 2024 19:19
@Jtang-1 Jtang-1 restored the jt/clear-on-search branch January 22, 2024 21:42
@Jtang-1
Copy link
Contributor Author

Jtang-1 commented Jan 22, 2024

duplicate this PR bb14258 6e85c85

@Jtang-1 Jtang-1 deleted the jt/clear-on-search branch January 22, 2024 21:45
@shubham1g5
Copy link
Contributor

@Robert-Costello Can we add the model change to the suite wiki as well. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants