Use System.lineSeparator in XmlUtil (for Windows compatibility) #1410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
duplicate this PR |
shubham1g5
previously approved these changes
May 30, 2024
FP already seems to have this change , @OrangeAndGreen think we should pull up this file from |
|
Merged the other changes that were on formplayer for XmlUtil, the two files are now identical |
|
thanks, looks like you probably also need to replicate xml used in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced a usage of '\n' with System.lineSeparator() in XmlUtil.
This fixes a broken unit test when running on a Windows machine.