This repository has been archived by the owner on Aug 27, 2018. It is now read-only.
Fixed SG not generating proper configs #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UnseenFaith
previously requested changes
Sep 14, 2017
src/providers/collection.js
Outdated
| @@ -6,12 +6,12 @@ exports.getTable = table => this.database.get(table) || this.database.set(table, | |||
|
|
|||
| exports.getAll = (table) => { | |||
There was a problem hiding this comment.
This should be changed to
exports.getAll(table) => {
return Array.from(this.getTable(table).values());
}getTable will automatically create the table for you (as it should), which means there will never be a time when the table doesn't exist and therefore no reason to check for the collection beforehand or return an empty array/null
There was a problem hiding this comment.
exports.getAll(table) => Array.from(this.getTable(table).values());actually this^
CyberiumShadow
dismissed stale reviews from UnseenFaith and kyranet
Changes Made manually
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Semver Increment Bump: [MAJOR/MINOR/PATCH]
PATCH
Changes Proposed in this Pull Request (List new items in CHANGELOG.MD)
(If Applicable) What Issue does it fix?