Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure users are being removed from global cache #113

Closed
Auralytical opened this issue Jul 9, 2016 · 3 comments
Closed

Ensure users are being removed from global cache #113

Auralytical opened this issue Jul 9, 2016 · 3 comments
Labels
enhancement project: websocket stability
Milestone
1.1

Comments

@Auralytical
Copy link
Collaborator

This was never actually tested as far as I know - users should be removed from global cache when they are no longer in any visible guild, nor have a current dm channel.
@Auralytical Auralytical added this to the 1.0 milestone Jul 9, 2016
@Auralytical Auralytical modified the milestones: 1.0, 1.0 Beta Jul 16, 2016
@Auralytical
Copy link
Collaborator Author

With the removal of shared datastore support, I wonder if this system can be made much more solid using WeakReferences...

@Auralytical Auralytical modified the milestones: 1.0, 1.0 Beta Aug 1, 2016
@Auralytical
Copy link
Collaborator Author

I recently patched one of these memory leaks as part the DownloadUsersAsync fix. We should check if this is still a problem.

@Auralytical Auralytical modified the milestones: 1.0 RC, 1.0 Nov 19, 2016
@khionu
Copy link
Contributor

khionu commented Jan 1, 2017

This can be tested as part of #272

@Auralytical Auralytical modified the milestones: 1.1, 1.0 Mar 31, 2017
@LassieME LassieME mentioned this issue May 3, 2017
Merged
@quinchs quinchs closed this as completed Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement project: websocket stability
Projects
None yet
Milestone
1.1
Development

No branches or pull requests
3 participants
@Auralytical @khionu @quinchs