Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: permission overwrite bits on old and new channel in channelUpdate are the same #6082

Closed
almostSouji opened this issue Jul 9, 2021 · 0 comments · Fixed by #6083

Comments

@almostSouji
Copy link
Member

almostSouji commented Jul 9, 2021

Please describe the problem you are having in as much detail as possible:

Permission overwrites on old and new channel in channelUpdate are the same, making the permission bits from before the update inaccessible.

Include a reproducible code sample here, if possible:

client.on('channelUpdate', (o, n) => {
	if (o instanceof DMChannel || n instanceof DMChannel) return;
	console.log(inspect(o.permissionOverwrites.cache, { depth: 10 }));
	console.log(inspect(n.permissionOverwrites.cache, { depth: 10 }));
});

Steps to reproduce:

  1. create channel
  2. add permission overwrite for a user or role
  3. observe same permission bits in the modified field allow/deny in both old and new channel

Further details:

regression introduced in #5318

  • discord.js version: e7ad2fe
  • Node.js version: v15.14.0
  • Operating system: -
  • Priority this issue should have – please be realistic and elaborate if possible: high
  • I have also tested the issue on latest master, commit hash: 5b6be0c
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant