Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More documentation, examples for remote parameters #31

Open
mbechard opened this issue Apr 5, 2022 · 3 comments
Open

More documentation, examples for remote parameters #31

mbechard opened this issue Apr 5, 2022 · 3 comments
Labels
documentation Improvements or additions to documentation

Comments

@mbechard
Copy link

mbechard commented Apr 5, 2022

Although I can make assumption on how this works. It'd be good if getting remote parameters had more documentation. If I have a mix of numbers, poses, images, and text, how are they retrieved?
I assume I separate the types and collapse the indices down. For number/poses I assume they are tightly packed so a float for a number followed by 16 floats for a pose followed by another float for a number.
Is that correct?
Are the indices for the rs_getFrameText() collapsed down or are those the index of the text parameter in the whole remote parameter list?

Thanks

@husberg-disguise husberg-disguise added the documentation Improvements or additions to documentation label Apr 6, 2022
@husberg-disguise
Copy link
Contributor

Yes, separated by type and collapsed. Currently the UE plugin source is the best reference: https://github.com/disguise-one/RenderStream-UE/blob/r1.29_UE4.27/Source/RenderStream/Private/RenderStreamSceneSelector.cpp#L296

We're internally debating whether to change the API to be clearer or write helper C++ classes to hide the complexity, but we'll hopefully have something before the next release.

@twhittock
Copy link
Contributor

The RenderStream-py repo has https://github.com/disguise-one/RenderStream-py/blob/11ab345cc3a9adfa953176532907d60528c8da3b/src/renderstream/renderstream.py#L700 which is a high level example of how to get all frame parameters. We'll be adding documentation and a C++ wrapper in this repository soon with a similar implementation so it's less opaque.

@twhittock
Copy link
Contributor

https://github.com/disguise-one/RenderStream/blob/r1.30/src/include/renderstream.hpp has a rough and ready C++ wrapper which shows the behaviour. Will add documentation to describe the process too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Development

No branches or pull requests

3 participants