Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we eliminate task-specific HPKE keys? #1641

Closed
inahga opened this issue Jul 24, 2023 · 1 comment
Closed

Should we eliminate task-specific HPKE keys? #1641

inahga opened this issue Jul 24, 2023 · 1 comment

Comments

@inahga
Copy link
Contributor

inahga commented Jul 24, 2023

From discussion in https://isrg.slack.com/archives/C0167LT4C73/p1689871160489639?thread_ts=1689810185.430009&cid=C0167LT4C73.

Since we must implement global HPKE keys for taskprov (or more precisely, task-independent HPKE configuration), we can consider doing away with task-specific HPKE keys entirely.

The main possible benefit is that we don't have to worry about per-task HPKE key rotation. It's more difficult to implement than for global HPKE keys, since we have to manage a set of keys for each discrete task. (Note that we could just never rotate a task HPKE and just let them age out).

Possible drawbacks:

  • The subscriber can never be in control over a global key. (i.e. they may want to choose different ciphers, but this could be mitigated by having a wide set of global keys using different ciphers to choose from).
  • Could have a large blast radius if a global key is compromised (although in the current architecture, if any report encryption key is leaked it's highly likely they're all compromised).
  • Spinning up janus from scratch is slightly more complicated, because the operator has to provision a global key after the database schema is applied.
@inahga
Copy link
Contributor Author

inahga commented Oct 18, 2023

Superseded by #2147

@inahga inahga closed this as completed Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant