-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DRF 3.5 '__all__' syntax for fields breaks GeoFeatureModelSerializer.add_to_fields #119
Comments
Raised by DRF 3.5. Related to #119 - I've used a workaround here.
At the moment I haven't looked in how to fix this but I have worked around it by using See commit 6479949. |
@sebasmagri: commit 654cc8b should fix the issue, I would really appreciate if you could double check if this statement is true |
@sebasmagri: did you have a chance to test the fix? |
@nemesisdesign sorry about the delay. I'll check this out today and let you know. |
I forgot to close this issue, which was fixed a while ago. |
Bumps [djangorestframework-gis](https://github.com/openwisp/django-rest-framework-gis) from 1.0 to 1.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/openwisp/django-rest-framework-gis/releases">djangorestframework-gis's releases</a>.</em></p> <blockquote> <h2>1.1.0 [2024-08-17]</h2> <h2>Features</h2> <ul> <li>Allowed <code>GeoFeatureModelSerializer</code> to support models without geometry field.</li> </ul> <h2>Changes</h2> <p><strong>Dependencies:</strong></p> <ul> <li> <p>Bumped <code>django-filters~=23.5</code>.</p> </li> <li> <p>Added Django <code>4.2</code>, <code>5.0</code>, <code>5.1</code> to automated testing build.</p> </li> <li> <p>Dropped several EOL dependencies from automated testing build:</p> <ul> <li>Python <code>3.6</code> and <code>3.7</code>.</li> <li>Django <code>2.2</code>, <code>3.0</code>, <code>3.1</code> and <code>4.0</code>.</li> <li><code>djangorestframework < 3.12</code>.</li> </ul> <p>The library may continue working with the dependencies listed above, but it's not guaranteed.</p> </li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/openwisp/django-rest-framework-gis/blob/master/CHANGES.rst">djangorestframework-gis's changelog</a>.</em></p> <blockquote> <h2>Version 0.11.1 [2017-05-05]</h2> <ul> <li><code>[#119](openwisp/django-rest-framework-gis#119) <https://github.com/openwisp/django-rest-framework-gis/issues/119></code>_: Added support to "<strong>all</strong>" fields in serializer</li> <li><code>[#130](openwisp/django-rest-framework-gis#130) <https://github.com/openwisp/django-rest-framework-gis/pull/130></code>_: Added compatibility with DRF 3.6</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/openwisp/django-rest-framework-gis/commit/927c9ee8bbbbeb5d9c1b3711314d3e12f9efe638"><code>927c9ee</code></a> 1.1.0 release</li> <li><a href="https://github.com/openwisp/django-rest-framework-gis/commit/533567afdf534f9173d6444e8c3941cf55ab036e"><code>533567a</code></a> [deps] Allow djangorestframework up to 3.15.x</li> <li><a href="https://github.com/openwisp/django-rest-framework-gis/commit/344978526e0178a070d54da1d78c536ca933e63a"><code>3449785</code></a> [deps] Update psycopg2 requirement from ~=2.8.0 to ~=2.9.9</li> <li><a href="https://github.com/openwisp/django-rest-framework-gis/commit/00096c00fd063b35fd8708d15de7e384f92632f3"><code>00096c0</code></a> [deps] Update django-filter requirement from ~=23.5 to >=23.5,<25.0</li> <li><a href="https://github.com/openwisp/django-rest-framework-gis/commit/2f6df048808381a6d2d57d4ef0479ac6a1eb8af5"><code>2f6df04</code></a> [deps/ci] QA reformat, updated CI, updated deps</li> <li><a href="https://github.com/openwisp/django-rest-framework-gis/commit/110abaa93fff083ad98f9f2d61bac58af46ba425"><code>110abaa</code></a> [docs] Added Issue Template, PR Template</li> <li><a href="https://github.com/openwisp/django-rest-framework-gis/commit/01e43df9849feaaa8ee259e54ce19e2e7d8ce1cd"><code>01e43df</code></a> [deps] Update openwisp-utils[qa] requirement from ~=1.0.0 to ~=1.0.5</li> <li><a href="https://github.com/openwisp/django-rest-framework-gis/commit/33df16cf2f25b12af2dfe7765915438967b081d2"><code>33df16c</code></a> [deps] Enabled dependabot</li> <li><a href="https://github.com/openwisp/django-rest-framework-gis/commit/4e661aaccf0c131e50d65291fa99ddcdf5f971d8"><code>4e661aa</code></a> [docs] Fixed build status badge</li> <li><a href="https://github.com/openwisp/django-rest-framework-gis/commit/4f244d5d8a7ad5b453fd04f64150818d15123e01"><code>4f244d5</code></a> [feature] Allow geometry-less models <a href="https://redirect.github.com/openwisp/django-rest-framework-gis/issues/282">#282</a></li> <li>Additional commits viewable in <a href="https://github.com/openwisp/django-rest-framework-gis/compare/v1.0.0...v1.1.0">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=djangorestframework-gis&package-manager=pip&previous-version=1.0&new-version=1.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
I'm getting the following traceback after using the 'all' syntax for serializer fields and drf-gis @ 7091af2:
I've worked this around by falling back to the iterable syntax on fields. However, I'm not completely sure about how drf-gis should handle this to help providing a fix.
The text was updated successfully, but these errors were encountered: