Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Roadmap] 1.2.0 Roadmap #5734

Closed
14 tasks done
hcho3 opened this issue May 31, 2020 · 17 comments
Closed
14 tasks done

[Roadmap] 1.2.0 Roadmap #5734

hcho3 opened this issue May 31, 2020 · 17 comments

Comments

@hcho3
Copy link
Collaborator

hcho3 commented May 31, 2020

@dmlc/xgboost-committer Please add your items here by editing this post. Let's ensure that

  • Each item has to be associated with a ticket
  • Major design/refactoring are associated with a RFC before committing the code
  • Blocking issue must be marked as blocking
  • Breaking change must be marked as breaking

For other contributors who have no permission to edit the post, please comment here about what you think should be in 1.2.0.

Blocking pull requests

Breaking change:

@hcho3 hcho3 pinned this issue May 31, 2020
@thvasilo
Copy link
Contributor

thvasilo commented Jun 8, 2020

Regarding distributed learning, Databricks has this big warning on their XGBoost docs: a cluster running Spark has to be re-started if an XGBoost job fails.

This is bad user experience, as a shared cluster might be running a number of other things and it would have to be shut down when a job fails, killing everything else.

The related issue #4826 hasn't had an update in a long time, so not sure if that's still the case with 1.1.0.

@ldesreumaux
Copy link
Contributor

ldesreumaux commented Jun 10, 2020

Is there any plan on making the Json serialization method no-longer "experimental" in version 1.2.0? What is the current status on this? Is the Json format currently stable or should we expect big changes in future releases?

@thvasilo
Copy link
Contributor

I'll also bring up re-visiting the default parameters issue, #4986 and the linked issue there, 1.2.0 might be a good point to at least change the min_child_weight.

@hcho3
Copy link
Collaborator Author

hcho3 commented Jun 16, 2020

@ldesreumaux We would like to remove the experimental label after we make JSON serialization robust. #5772 adds a whole suite of tests to ensure that floating-point values are preserved by JSON serialization.

@trivialfis
Copy link
Member

I'll also bring up re-visiting the default parameters issue, #4986 and the linked issue there, 1.2.0 might be a good point to at least change the min_child_weight.

I think we will have to do it in next release. Which is not a bad thing, I'm targeting cat data support so we might unify a lots of internal code and will be able to support a unified set of parameters.

@thvasilo
Copy link
Contributor

Is categorical data support planned for 1.2.0 @trivialfis ?

@hcho3
Copy link
Collaborator Author

hcho3 commented Jul 23, 2020

@dmlc/xgboost-committer It's been more than 2 months since we release 1.1.0, and we made 130 commits since then. Let's think about releasing 1.2.0 soon. Consider which pull requests are blocking.

@CodingCat
Copy link
Member

I think #5929 is definitely something BLOCKING

#5171 is something good to have as the first version supporting Spark 3.0 with a GPU capability

@trivialfis
Copy link
Member

Removed from the roadmap.

@hcho3
Copy link
Collaborator Author

hcho3 commented Jul 24, 2020

Added blocking PRs

@wbo4958
Copy link
Contributor

wbo4958 commented Jul 24, 2020

I can add gpu_hist unit test today, @CodingCat @hcho3

@hcho3
Copy link
Collaborator Author

hcho3 commented Jul 24, 2020

@wbo4958 I marked gpu_hist as "blocking". We'll make sure it's included in 1.2.0.

@hcho3
Copy link
Collaborator Author

hcho3 commented Jul 24, 2020

@thvasilo Categorical data support won't be included in 1.2.0. cc @trivialfis

@trivialfis
Copy link
Member

trivialfis commented Jul 30, 2020

@hcho3 Can we branch out?

@hcho3
Copy link
Collaborator Author

hcho3 commented Jul 30, 2020

Sure, let me do that this Friday.

@hcho3
Copy link
Collaborator Author

hcho3 commented Aug 1, 2020

Now that all blocking PRs have been merged, let me prepare a new release branch.

@hcho3 hcho3 mentioned this issue Aug 2, 2020
9 tasks
@hcho3 hcho3 unpinned this issue Aug 2, 2020
@hcho3 hcho3 closed this as completed Aug 25, 2020
@hcho3
Copy link
Collaborator Author

hcho3 commented Aug 25, 2020

1.2.0 is now released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants