Skip to content
This repository has been archived by the owner on Dec 12, 2018. It is now read-only.

Thrift server doesn't always die with Ctrl-C #5

Open
dmnapolitano opened this issue Jul 15, 2013 · 0 comments
Open

Thrift server doesn't always die with Ctrl-C #5

dmnapolitano opened this issue Jul 15, 2013 · 0 comments
Labels

Comments

@dmnapolitano
Copy link
Owner

Reproducible with the factored parser model. Doesn't occur with the PCFG model. Model choice probably has nothing to do with any of this.

Wednesday, June 05, 2013 4:18 PM
Heilman, Michael
Hi Diane,

When you get a chance, could you please add a shutdown handler to close the connections and exit gracefully so we don't have these issues with ports being left open?

I can see the concern about people shutting down other people's servers, but I think the need for a clean way to shut down our own servers outweighs that.

Also, it would probably be good to add handlers for kill signals and such, but that might get a bit complicated...
http://stackoverflow.com/questions/10689772/tprocesspoolserver-graceful-shutdown

Also, I'm guessing this might take a while, or that you probably have other things to do right now, so I'm going to start using the servers that are already up (or the one on slave06:9999 at least). So, please don't restart the servers right away. Maybe wait until the next time we need to take them down (?).

Thanks,
Mike

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant