Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ability to provide custom user_agent would be nice #5

Closed
matkoniecz opened this issue Mar 8, 2023 · 4 comments
Closed

ability to provide custom user_agent would be nice #5

matkoniecz opened this issue Mar 8, 2023 · 4 comments

Comments

@matkoniecz
Copy link
Contributor

Especially as APIs often block/rate limit queries without user agent or ones being abusive
@docentYT
Copy link
Owner

docentYT commented Mar 8, 2023

Better to make the possibility of setting the user_agent global for all modules or separately for API and diff?

@matkoniecz
Copy link
Contributor Author

As a parameter in api/diff seems more clear than some hackish global variable. Especially as server is set there already.

@docentYT
Copy link
Owner

docentYT commented Mar 9, 2023

https://github.com/docentYT/osm_easy_api/tree/development

@docentYT docentYT mentioned this issue Mar 14, 2023
Merged
@docentYT
Copy link
Owner

https://github.com/docentYT/osm_easy_api/releases/tag/v0.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@matkoniecz @docentYT