Skip to content
This repository has been archived by the owner on Jun 13, 2021. It is now read-only.

Add inspect command to display info of running application only #721

Merged
merged 4 commits into from
Nov 12, 2019

Conversation

glours
Copy link
Contributor

@glours glours commented Oct 29, 2019

- What I did
Add an app inspect command to display info on running applications

- How I did it
Create a new command
Display information from Installation Claim for Installation, Application & Parameters section
Call the status CNAB action to display the list of running services

- How to verify it
TBD

- Description for the changelog
Add a new inspect command to display information on running applications

- A picture of a cute animal (not mandatory but encouraged)
image

@glours glours changed the title WIP Add inspect command to display info of running application only [WIP] Add inspect command to display info of running application only Oct 29, 2019
@glours glours force-pushed the inspect_info_running_app_only branch 7 times, most recently from 269b4f0 to 3859f01 Compare November 4, 2019 16:53
@codecov
Copy link

codecov bot commented Nov 6, 2019

Codecov Report

Merging #721 into master will decrease coverage by 0.87%.
The diff coverage is 54.43%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #721      +/-   ##
=========================================
- Coverage   70.48%   69.6%   -0.88%     
=========================================
  Files          62      63       +1     
  Lines        3208    3349     +141     
=========================================
+ Hits         2261    2331      +70     
- Misses        641     710      +69     
- Partials      306     308       +2
Impacted Files Coverage Δ
internal/names.go 100% <ø> (ø) ⬆️
internal/commands/root.go 72.36% <100%> (+0.36%) ⬆️
internal/packager/cnab.go 97.94% <100%> (+0.03%) ⬆️
internal/commands/inspect.go 18.29% <18.29%> (ø)
internal/inspect/inspect.go 88.7% <93.05%> (+1.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 080e680...7670989. Read the comment docs.

@jcsirot jcsirot force-pushed the inspect_info_running_app_only branch from f230365 to 02a1d4e Compare November 7, 2019 13:28
internal/commands/inspect.go Outdated Show resolved Hide resolved
internal/commands/inspect.go Outdated Show resolved Hide resolved
internal/commands/inspect.go Outdated Show resolved Hide resolved
@jcsirot jcsirot force-pushed the inspect_info_running_app_only branch 5 times, most recently from 25400b6 to e6522c7 Compare November 8, 2019 12:09
@jcsirot jcsirot force-pushed the inspect_info_running_app_only branch from e6522c7 to 5c6c2d2 Compare November 8, 2019 12:31
@jcsirot jcsirot marked this pull request as ready for review November 8, 2019 12:50
@glours glours changed the title [WIP] Add inspect command to display info of running application only Add inspect command to display info of running application only Nov 8, 2019
cmd/cnab-run/status.go Outdated Show resolved Hide resolved
Copy link
Member

@rumpl rumpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of Qs but LGTM after they are treated

@rumpl
Copy link
Member

rumpl commented Nov 8, 2019

Is the coverage completely wrong or does this PR really reduces the coverage?

@jcsirot jcsirot force-pushed the inspect_info_running_app_only branch from 5c6c2d2 to 8abe274 Compare November 8, 2019 13:34
Signed-off-by: Jean-Christophe Sirot <[email protected]>
@jcsirot jcsirot force-pushed the inspect_info_running_app_only branch from 8abe274 to 7670989 Compare November 8, 2019 14:13
Copy link
Member

@eunomie eunomie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eunomie eunomie merged commit 4e0989c into docker:master Nov 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants