render command renders App image only #724
Conversation
…name. Rendering a .dockerapp dir is not allowed anymore Signed-off-by: Jean-Christophe Sirot <[email protected]>
jcsirot
force-pushed
the
app-render-image-only
branch
from
bce6701
to
c638020
Compare
internal/commands/render.go
Outdated
| if err != nil { | ||
| if strings.HasSuffix(appname, ".dockerapp") { | ||
| return nil, nil, nil, fmt.Errorf("%q looks like a docker App directory and App must be built first before rendering", appname) |
There was a problem hiding this comment.
Do we really want to be this specific? If we do, then why not print out the command the user needs to run to build the app?
There was a problem hiding this comment.
Maybe we could do the same as in docker app image tag who throw this type of error: "could not tag %q: no such App image". So here something like: "could not render %q: no such App image"?
internal/commands/render.go
Outdated
| if err != nil { | ||
| if strings.HasSuffix(appname, ".dockerapp") { |
There was a problem hiding this comment.
Maybe this test should be moved to cnab.GetBundle ? So all the commands would have the same behavior?
There was a problem hiding this comment.
Maybe we should just remove the check for .dockerapp? What if I want to name my application toto.dockerapp?
There was a problem hiding this comment.
If your application is toto.dockerapp the GetBundle should return a bundle and triggers no error but I'm also wondering if having that specific warning for .dockerapp is useful
Signed-off-by: Jean-Christophe Sirot <[email protected]>
jcsirot
force-pushed
the
app-render-image-only
branch
from
c638020
to
7263c18
Compare
Codecov Report
@@ Coverage Diff @@
## master #724 +/- ##
==========================================
+ Coverage 71.49% 71.82% +0.32%
==========================================
Files 59 59
Lines 3280 3329 +49
==========================================
+ Hits 2345 2391 +46
- Misses 605 606 +1
- Partials 330 332 +2
Continue to review full report at Codecov.
|
Signed-off-by: Jean-Christophe Sirot <[email protected]>
- What I did
This PR ensure that the
docker app rendertakes a App image reference argument and fails when a.dockerappdirectory is used. If the image is not present locally in the bundle store, the App image is automatically fetched.- How to verify it
Run
docker app render myapp.dockerappand verify it fails with an error indicating that App must be built first.Run
docker app render myapp:mytag --set param=some_valueand verify the app is correctly rendered.- A picture of a cute animal (not mandatory but encouraged)
