This repository has been archived by the owner on Jun 13, 2021. It is now read-only.
Download Docker CLI instead of building it #730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndeloof
approved these changes
Nov 7, 2019
chris-crone
force-pushed
the
download-cli
branch
2 times, most recently
from
1effbfb
to
c2ed96b
Compare
Download the macOS and Linux Docker CLI from download.docker.com instead of building them. Signed-off-by: Christopher Crone <[email protected]>
chris-crone
force-pushed
the
download-cli
branch
from
c2ed96b
to
88fcef1
Compare
Codecov Report
@@ Coverage Diff @@
## master #730 +/- ##
=========================================
- Coverage 70.57% 70.48% -0.1%
=========================================
Files 62 62
Lines 3208 3208
=========================================
- Hits 2264 2261 -3
- Misses 639 641 +2
- Partials 305 306 +1
Continue to review full report at Codecov.
|
rumpl
approved these changes
Nov 8, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Download the CLI for macOS and Linux as they are available on download.docker.com. This should make the build slightly faster.
Note the CLI is only used for testing – we do not ship it.
- How I did it
Replace build with curl.
- How to verify it
Existing tests should pass.
- Description for the changelog
N/A
- A picture of a cute animal (not mandatory)