-
Notifications
You must be signed in to change notification settings - Fork 177
Conversation
8da9efd
to
56a36d2
Compare
56a36d2
to
8aea17b
Compare
Codecov Report
@@ Coverage Diff @@
## master #758 +/- ##
=========================================
Coverage ? 69.15%
=========================================
Files ? 64
Lines ? 3469
Branches ? 0
=========================================
Hits ? 2399
Misses ? 751
Partials ? 319 Continue to review full report at Codecov.
|
result.port 9000 | ||
vote.port 8080 | ||
vote.replicas 5 | ||
Now, we will update the running App to overwrite the current parameters with the production parameters we created at the previous step. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now, we will update the running App to overwrite the current parameters with the production parameters we created at the previous step. | |
Now, we will update the running App to overwrite the current parameters with the production parameters we created in the previous step. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM just one final nit
Signed-off-by: Caroline Briaud <[email protected]>
8aea17b
to
5b75fab
Compare
Signed-off-by: Caroline Briaud [email protected]
- What I did
Update voting-app example to take into account UX changes
Fix a typo in hello-world example
- How to verify it
Check the readme and file renamed
- A picture of a cute animal (not mandatory)