Skip to content
This repository has been archived by the owner on Jun 13, 2021. It is now read-only.

Introduce Arm64 support #777

Merged
merged 5 commits into from
Dec 9, 2019
Merged

Conversation

silvin-lubecki
Copy link
Contributor

- What I did
Introduce Arm64 support for docker-app.

- How I did it

  • Cross build docker-app plugin to linux-amd64 platform
  • Cross build cnab-app-base image to linux-arm64 platform
  • Create a manifest list and push it to the hub using docker manifest commands

- How to verify it

  • Push a test tag and check on Hub if the image is multi-arch.

- Description for the changelog

  • Add Arm64 support for docker-app plugin
  • docker/cnab-app-base is now a multi-arch image with linux/arm64 platform

- A picture of a cute animal (not mandatory)
image

@codecov
Copy link

codecov bot commented Dec 4, 2019

Codecov Report

Merging #777 into master will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #777      +/-   ##
==========================================
- Coverage    70.4%   70.32%   -0.09%     
==========================================
  Files          67       67              
  Lines        3740     3740              
==========================================
- Hits         2633     2630       -3     
- Misses        760      762       +2     
- Partials      347      348       +1
Impacted Files Coverage Δ
types/parameters/parameters.go 92.06% <0%> (-4.77%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 012748d...743f7fc. Read the comment docs.

@silvin-lubecki silvin-lubecki marked this pull request as ready for review December 4, 2019 16:46
@silvin-lubecki
Copy link
Contributor Author

@doanac I'd love your review here 😄

@doanac
Copy link
Contributor

doanac commented Dec 4, 2019

Thanks! I hate to be too demanding, but would this be a good time to also do armhf as well? We actually use both aarch64 and armhf in our products.

@doanac
Copy link
Contributor

doanac commented Dec 4, 2019

thanks so much!

@silvin-lubecki
Copy link
Contributor Author

silvin-lubecki commented Dec 4, 2019

thanks so much!

You're welcome 😸 Well, it still needs to pass the CI, but it's just a matter of time.
@doanac can I ask you to check this PR on your side?

Copy link
Contributor

@ulyssessouza ulyssessouza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@silvin-lubecki silvin-lubecki merged commit 1cfb232 into docker:master Dec 9, 2019
@silvin-lubecki silvin-lubecki deleted the arm-build branch December 9, 2019 15:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants