Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for --invoke for v0.9 #1258

Closed
tonistiigi opened this issue Aug 8, 2022 · 1 comment · Fixed by #1259
Closed

Fixes for --invoke for v0.9 #1258

tonistiigi opened this issue Aug 8, 2022 · 1 comment · Fixed by #1259
Milestone

Comments

@tonistiigi
Copy link
Member

I think it is worth doing some small updates to --invoke so we can get better feedback when we release this as experimental in v0.9.

  • On initial launch of the debug container, a message should be printed "Launching interactive container. Press Ctrl-a-c to switch to monitor console".
  • There should be "help" command that lists the currently available commands. Typing unknown command should also show help or show "Run help to see all supported commands".

Nice to have:

  • Output warnings should be suppressed then running --invoke. "WARNING: No output specified " is not relevant.
  • After issuing "rollback" command would be nice to show message "Interactive container was restarted. Press Ctrl-a-c to switch to the new container".
  • On monitor mode, if there is no active container and Ctrl-a-c is pressed, a message could show "No running interactive containers. You can start one by issuing rollback command".

@ktock (or others) LMK if you would like to take some of these; otherwise, I can look into them myself as well.

@tonistiigi tonistiigi added this to the v0.9.0 milestone Aug 8, 2022
@ktock
Copy link
Collaborator

ktock commented Aug 8, 2022

Thanks for the suggestion. I'll take it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants