From 3971361ed2132c149eb6686909ec8a4e7243422b Mon Sep 17 00:00:00 2001 From: Eli Treuherz Date: Fri, 21 Jun 2024 11:56:54 +0100 Subject: [PATCH 1/2] Pass in index annotations from builds on multiple nodes Fixes #2540 Signed-off-by: Eli Treuherz --- build/build.go | 15 ++++++++++++++- commands/imagetools/create.go | 8 +++++++- controller/build/build.go | 5 ++++- util/imagetools/create.go | 9 ++------- 4 files changed, 27 insertions(+), 10 deletions(-) diff --git a/build/build.go b/build/build.go index 1d06824ac83..75373e64de1 100644 --- a/build/build.go +++ b/build/build.go @@ -61,6 +61,7 @@ type Options struct { Ref string Allow []entitlements.Entitlement + Annotations map[exptypes.AnnotationKey]string Attests map[string]*string BuildArgs map[string]string CacheFrom []client.CacheOptionsEntry @@ -607,7 +608,8 @@ func BuildWithResultHandler(ctx context.Context, nodes []builder.Node, opt map[s } } - dt, desc, err := itpull.Combine(ctx, srcs, nil, false) + filteredAnnotations := filterIndexAnnotations(opt.Annotations) + dt, desc, err := itpull.Combine(ctx, srcs, filteredAnnotations, false) if err != nil { return err } @@ -655,6 +657,17 @@ func BuildWithResultHandler(ctx context.Context, nodes []builder.Node, opt map[s return resp, nil } +func filterIndexAnnotations(annotations map[exptypes.AnnotationKey]string) map[exptypes.AnnotationKey]string { + filteredAnnotations := map[exptypes.AnnotationKey]string{} + for k, v := range annotations { + switch k.Type { + case exptypes.AnnotationIndex, exptypes.AnnotationManifestDescriptor: + filteredAnnotations[k] = v + } + } + return filteredAnnotations +} + func pushWithMoby(ctx context.Context, d *driver.DriverHandle, name string, l progress.SubLogger) error { api := d.Config().DockerAPI if api == nil { diff --git a/commands/imagetools/create.go b/commands/imagetools/create.go index 934602ee6ef..05f460d777d 100644 --- a/commands/imagetools/create.go +++ b/commands/imagetools/create.go @@ -9,6 +9,7 @@ import ( "github.com/distribution/reference" "github.com/docker/buildx/builder" + "github.com/docker/buildx/util/buildflags" "github.com/docker/buildx/util/cobrautil/completion" "github.com/docker/buildx/util/imagetools" "github.com/docker/buildx/util/progress" @@ -154,7 +155,12 @@ func runCreate(ctx context.Context, dockerCli command.Cli, in createOptions, arg } } - dt, desc, err := r.Combine(ctx, srcs, in.annotations, in.preferIndex) + annotations, err := buildflags.ParseAnnotations(in.annotations) + if err != nil { + return errors.Wrapf(err, "failed to parse annotations") + } + + dt, desc, err := r.Combine(ctx, srcs, annotations, in.preferIndex) if err != nil { return err } diff --git a/controller/build/build.go b/controller/build/build.go index 1cae9b6c70d..57b4353c659 100644 --- a/controller/build/build.go +++ b/controller/build/build.go @@ -136,8 +136,9 @@ func RunBuild(ctx context.Context, dockerCli command.Cli, in controllerapi.Build annotations, err := buildflags.ParseAnnotations(in.Annotations) if err != nil { - return nil, nil, err + return nil, nil, errors.Wrap(err, "parse annotations") } + for _, o := range outputs { for k, v := range annotations { o.Attrs[k.String()] = v @@ -146,6 +147,8 @@ func RunBuild(ctx context.Context, dockerCli command.Cli, in controllerapi.Build opts.Exports = outputs + opts.Annotations = annotations + opts.CacheFrom = controllerapi.CreateCaches(in.CacheFrom) opts.CacheTo = controllerapi.CreateCaches(in.CacheTo) diff --git a/util/imagetools/create.go b/util/imagetools/create.go index 08148ad28c6..54cbf344b29 100644 --- a/util/imagetools/create.go +++ b/util/imagetools/create.go @@ -14,7 +14,6 @@ import ( "github.com/containerd/containerd/remotes" "github.com/containerd/errdefs" "github.com/distribution/reference" - "github.com/docker/buildx/util/buildflags" "github.com/moby/buildkit/exporter/containerimage/exptypes" "github.com/moby/buildkit/util/contentutil" "github.com/opencontainers/go-digest" @@ -29,7 +28,7 @@ type Source struct { Ref reference.Named } -func (r *Resolver) Combine(ctx context.Context, srcs []*Source, ann []string, preferIndex bool) ([]byte, ocispec.Descriptor, error) { +func (r *Resolver) Combine(ctx context.Context, srcs []*Source, ann map[exptypes.AnnotationKey]string, preferIndex bool) ([]byte, ocispec.Descriptor, error) { eg, ctx := errgroup.WithContext(ctx) dts := make([][]byte, len(srcs)) @@ -152,11 +151,7 @@ func (r *Resolver) Combine(ctx context.Context, srcs []*Source, ann []string, pr // annotations are only allowed on OCI indexes indexAnnotation := make(map[string]string) if mt == ocispec.MediaTypeImageIndex { - annotations, err := buildflags.ParseAnnotations(ann) - if err != nil { - return nil, ocispec.Descriptor{}, err - } - for k, v := range annotations { + for k, v := range ann { switch k.Type { case exptypes.AnnotationIndex: indexAnnotation[k.Key] = v From 6f45b0ea0658c312ed2763b59fed9aef965b9cea Mon Sep 17 00:00:00 2001 From: Eli Treuherz Date: Thu, 27 Jun 2024 13:25:41 +0100 Subject: [PATCH 2/2] Get annotations from exports Signed-off-by: Eli Treuherz --- build/build.go | 33 +++++++++++++++++++++++---------- controller/build/build.go | 2 -- 2 files changed, 23 insertions(+), 12 deletions(-) diff --git a/build/build.go b/build/build.go index 75373e64de1..fb312e4a111 100644 --- a/build/build.go +++ b/build/build.go @@ -61,7 +61,6 @@ type Options struct { Ref string Allow []entitlements.Entitlement - Annotations map[exptypes.AnnotationKey]string Attests map[string]*string BuildArgs map[string]string CacheFrom []client.CacheOptionsEntry @@ -608,8 +607,12 @@ func BuildWithResultHandler(ctx context.Context, nodes []builder.Node, opt map[s } } - filteredAnnotations := filterIndexAnnotations(opt.Annotations) - dt, desc, err := itpull.Combine(ctx, srcs, filteredAnnotations, false) + indexAnnotations, err := extractIndexAnnotations(opt.Exports) + if err != nil { + return err + } + + dt, desc, err := itpull.Combine(ctx, srcs, indexAnnotations, false) if err != nil { return err } @@ -657,15 +660,25 @@ func BuildWithResultHandler(ctx context.Context, nodes []builder.Node, opt map[s return resp, nil } -func filterIndexAnnotations(annotations map[exptypes.AnnotationKey]string) map[exptypes.AnnotationKey]string { - filteredAnnotations := map[exptypes.AnnotationKey]string{} - for k, v := range annotations { - switch k.Type { - case exptypes.AnnotationIndex, exptypes.AnnotationManifestDescriptor: - filteredAnnotations[k] = v +func extractIndexAnnotations(exports []client.ExportEntry) (map[exptypes.AnnotationKey]string, error) { + annotations := map[exptypes.AnnotationKey]string{} + for _, exp := range exports { + for k, v := range exp.Attrs { + ak, ok, err := exptypes.ParseAnnotationKey(k) + if !ok { + continue + } + if err != nil { + return nil, err + } + + switch ak.Type { + case exptypes.AnnotationIndex, exptypes.AnnotationManifestDescriptor: + annotations[ak] = v + } } } - return filteredAnnotations + return annotations, nil } func pushWithMoby(ctx context.Context, d *driver.DriverHandle, name string, l progress.SubLogger) error { diff --git a/controller/build/build.go b/controller/build/build.go index 57b4353c659..2118d7dab7f 100644 --- a/controller/build/build.go +++ b/controller/build/build.go @@ -147,8 +147,6 @@ func RunBuild(ctx context.Context, dockerCli command.Cli, in controllerapi.Build opts.Exports = outputs - opts.Annotations = annotations - opts.CacheFrom = controllerapi.CreateCaches(in.CacheFrom) opts.CacheTo = controllerapi.CreateCaches(in.CacheTo)