Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky test: TestInitTtySizeErrors() (on macOS "latest") #3441

Closed
thaJeztah opened this issue Feb 24, 2022 · 1 comment
Closed

Flaky test: TestInitTtySizeErrors() (on macOS "latest") #3441

thaJeztah opened this issue Feb 24, 2022 · 1 comment

Comments

@thaJeztah
Copy link
Member

Looks like this test is flaky on macOS ("latest"); could be due to macOS updates perhaps (but the "resize" code has been known to be somewhat racy/flaky, so perhaps some improvements are needed)

--- FAIL: TestInitTtySizeErrors (0.10s)
    tty_test.go:29: assertion failed: 
        --- expectedError
        +++ →
        @@ -1,2 +1 @@
        -failed to resize tty, using default size
@thaJeztah
Copy link
Member Author

Test flakiness was fixed in #3573 and #3584

There's some remaining work to be done, which is tracked through #3554

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant