Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'docker trust sign' does not work with manifest lists #910

Open
rn opened this issue Feb 28, 2018 · 2 comments
Open

'docker trust sign' does not work with manifest lists #910

rn opened this issue Feb 28, 2018 · 2 comments

Comments

@rn
Copy link

rn commented Feb 28, 2018

I created/pushed a new manifest list (using some LinuxKit images/repo for which signing is already set up:

$ docker manifest create linuxkit/auditd:test-sign \
    linuxkit/auditd:6ea41e1a0c3c0396703aa888f23e5dafcc4fd2bd-arm64 \
    linuxkit/auditd:6ea41e1a0c3c0396703aa888f23e5dafcc4fd2bd-amd64
$ docker manifest push linuxkit/auditd:test-sign

The manifest is available and inspectable.

The, I attempt to sign the manifest list:

$ docker trust sign linuxkit/auditd:test-sign
Error: No such image: linuxkit/auditd:test-sign
@dnephin
Copy link
Contributor

dnephin commented Feb 28, 2018

cc @n4ss do you know who can look into this?

@eiais
Copy link
Contributor

eiais commented Mar 6, 2018

This doesn't work for two reasons.

checkLocalImageExistence only returns local Images and doesn't check if a manifest is local. If that was modified to be checkLocalExistence for images and manifests it would break in sign.go on line 93 which calls image.TrustedPush.

If a manifest was signed first with notary then multisigning would work with trust sign.
AFAIK there isn't an equivalent to image.TrustedPush for manifests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants