This repository has been archived by the owner on Oct 13, 2023. It is now read-only.
[19.03 backport] atomic: patch 64bit alignment on 32bit systems #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
causes panic on armv7 Signed-off-by: Tonis Tiigi <[email protected]> (cherry picked from commit af2e82d) Signed-off-by: Sebastiaan van Stijn <[email protected]>
|
@AkihiroSuda @tonistiigi ptal |
AkihiroSuda
approved these changes
Sep 16, 2019
tonistiigi
approved these changes
Sep 16, 2019
|
It's a pity we don't have CI for ARM running (as far as I can see), but the change looks reasonable and minor. Merging |
|
@kolyshkin see moby#39678 |
|
oh, that's arm64 of course |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of moby#39543
fixes moby/buildkit#1079 Docker 18.09.7 nil pointer panic in builder-next/adapters/containerimage.(*cachedResolver).Resolve
causes panic on armv7