-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A cross-origin url on _coverpage file cannot be redirected to if "routerMode" is set to "history" #1379
Comments
I'm also facing the same issue. Sent from my OnePlus 5 using FastHub |
Yes, I have noticed this issue as well--I use some custom html in my coverpage, and standard html anchor links do nothing when you click on them, if router mode is set to "history". The same links work fine in "hash" routing mode. It looks like another Docsify user may have solved this with a custom plugin, but I'm not sure if it is possible to generalize: ml5js/ml5-library#985 |
Thx for ur report. window.$docsify = {
crossOriginLinks:[
"https://rstudio.com/auth-sign-in",
],
}; |
@Koooooo-7 Thank you for the solution, I tried the same and it worked as expected. I've solved the issue differently using href attribute '"target="_blank'. See below. <a href="https://rstudio.com/rsc/connect/#/login/" target="blank"> Adding the '"target="_blank' with the URL solved the issue by opening it in a different browser tab. |
Aha, no problem.
Cool. |
Bug Report
Steps to reproduce
Set these lines in index.html
Then use any other doman URLs in _coverpage file, See below...
<a href="https://rstudio.com/auth-sign-in">Login</a><br />
What is the current behavior
when clicking on the link on the cover page there is no response, while checking the browser console getting the following error.
Uncaught DOMException: Failed to execute 'pushState' on 'History': A history state object with URL 'https://rstudio.com/auth-sign-in' cannot be created in a document with origin 'https://datatools.inhouse.com' and URL 'https://datatools.inhouse.com/'.
at https://cdn.jsdelivr.net/npm/docsify/lib/docsify.min.js:1:93866
What is the expected behavior
Redirect to the mentioned web page directly.
Other relevant information
Bug does still occur when all/other plugins are disabled?
Your OS:
Using the docsify index.html file in an apache container, the apache server serves the web site.
Docsify version:
Using "src="//cdn.jsdelivr.net/npm/docsify/lib/docsify.min.js" " in the index page. I believe this will use the latest version of docsify.
Have you seen this issue with other docsify projects?
Yes, see A cross-origin url cannot be redirected to if "externalLinkTarget" is set to "_self" and "routerMode" is set to "history" #1046 @Koooooo-7 @anikethsaha
Docsify plugins:
Mentioned
index.html
and_coverpage
files are in the below repository. Please check it.Git repo
Mention the docsify version in which this bug was not present (if any)
The text was updated successfully, but these errors were encountered: