Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

":include" in double quotes doesn't recognized #1587

Closed
zdm opened this issue Jun 3, 2021 · 2 comments · Fixed by #1598
Closed

":include" in double quotes doesn't recognized #1587

zdm opened this issue Jun 3, 2021 · 2 comments · Fixed by #1598
Labels
bug confirmed as a bug

Comments

@zdm
Copy link

zdm commented Jun 3, 2021

Bug Report

Steps to reproduce

Try to embed external file using for example this link:

[readme](https://raw.githubusercontent.com/softvisio/core/main/README.md ":include")

What is current behaviour

Currently file will not be embedded, because :include tag is placed in double quotes.
This is the problem, because prettier markdown processor replaces single quotes with double and double quotes are legal for the link title.

What is the expected behaviour

I am expecting, that file will be embedded ti the parent document.

Other relevant information

  • [ x] Bug does still occur when all/other plugins are disabled?

  • Your OS:

  • Node.js version:

  • npm/yarn version:

  • Browser version:

  • Docsify version: 4.12.1

  • Docsify plugins:

Please create a reproducible sandbox

Edit 307qqv236

Mention the docsify version in which this bug was not present (if any)

@sy-records
Copy link
Member

you can use

[readme](https://raw.githubusercontent.com/softvisio/core/main/README.md "readme :include")

@trusktr
Copy link
Member

trusktr commented Jun 25, 2021

Will be fixed by #1598

@trusktr trusktr reopened this Jun 25, 2021
@trusktr trusktr added the bug confirmed as a bug label Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug confirmed as a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants