Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default behavoir should not be to emojify all, including non-emojis #1721

Closed
1 task done
ChoKaPeek opened this issue Jan 12, 2022 · 1 comment · Fixed by #1746
Closed
1 task done

default behavoir should not be to emojify all, including non-emojis #1721

ChoKaPeek opened this issue Jan 12, 2022 · 1 comment · Fixed by #1746

Comments

@ChoKaPeek
Copy link
Contributor

ChoKaPeek commented Jan 12, 2022

Bug Report

Any couple of colons gets emojified.

Steps to reproduce

  • have a md containing the following:

Namespace::SubNameSpace::Class hh:mm:ss :one::two:

What is current behaviour

It will create a string like this without the emoji plugin:

Namespace:<img class="emoji" src="https://github.githubassets.com/images/icons/emoji/SubNameSpace.png alt="SubNameSpace" />:Class hh<img class="emoji" src="https://github.githubassets.com/images/icons/emoji/mm.png alt="mm" />ss onetwo

What is the expected behaviour

with the emoji plugin:

Namespace::SubNameSpace::Class hh:mm:ss onetwo

without:

Namespace::SubNameSpace::Class hh:mm:ss :one::two:

Other relevant information

  • Bug does still occur when all/other plugins are disabled?

  • Your OS:

  • Node.js version:

  • npm/yarn version:

  • Browser version:

  • Docsify version: 4.12.2

  • Docsify plugins: none

Please create a reproducible sandbox

Mention the docsify version in which this bug was not present (if any)

@ChoKaPeek ChoKaPeek changed the title emojify emojies non-emojis default behavoir should not be to emojify all, including non-emojis Jan 12, 2022
@sy-records
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants