Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #664
Issue
prerenderEmbed
is using the actual cached value when there is a hit. The value (an array) gets cleared somehow during processing https://github.com/docsifyjs/docsify/blob/master/src/core/render/index.js#L159. By the time the cached value is hit again, though the value is notundefined
, the content is empty. Hence 404 shows up.Solution
Using a copy of cached value solves the problem.
Please makes sure these boxes are checked before submitting your PR, thank you!
master
branch.lib
directory.