[WIP] fix: cover page button style #670
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #665
Issue
CSS selector for cover page buttons are not working due to change of
marked
output. No<p>
wrapper anymore.Solution
Update CSS selector solves the problem.
Discussion
Although updating CSS selector solves the problem, it brings a potential issue: all direct child
<a>
tags of.cover-main
will now be rendered as a "cover page button".Another way of solving this might be adding a new wrapper to buttons, or add configs (
[GitHub](https://github.com/docsify :cover-page-button)
) to links to declare that they should be styled as "cover page buttons".@QingWei-Li what's your opinion?
Please makes sure these boxes are checked before submitting your PR, thank you!
master
branch.lib
directory.