Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sACN sent to the incorrect multicast address will still be recognized #252

Closed
docsteer opened this issue Jan 17, 2022 · 4 comments
Closed
Assignees
Labels
bug fixed in development branch Fixed in a development branch for the version milestone
Milestone

Comments

@docsteer
Copy link
Owner

If sACN is sent to the wrong multicast group (e.g. multicast data for universe 2 is sent to 239.255.0.1) the application will still recognize it as valid sACN.

We should either fail reception entirely in this case, or, show an error for the universe

@marcusbirkin
Copy link
Collaborator

This was, sort of, by design. It was a artifact of the unicast support.
Should we have a tickbox (enabled by default?) in preferences to allow reception on invalid multicast?

@docsteer
Copy link
Owner Author

I would vote for rejection by default - if I recall this caused confusion where someone was testing a device that didn't use multicast addresses correctly, sACNView showed it just fine but gateways wouldn't receive it. We don't want to encourage people to put hundreds of universes on one multicast address :-)

@marcusbirkin marcusbirkin added this to the v2.2 milestone Mar 7, 2023
@marcusbirkin marcusbirkin self-assigned this Mar 7, 2023
@marcusbirkin
Copy link
Collaborator

I'll skip the preferences option, it's getting full.... maybe later we have options to allow/disallow Broadcast/Multicast/Unicast/Wrong mutlicast/et cetera.
For now I'll just fix the bug!

@docsteer
Copy link
Owner Author

docsteer commented Mar 8, 2023

Resolved in v2.2.0-beta.1

@docsteer docsteer closed this as completed Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fixed in development branch Fixed in a development branch for the version milestone
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants