Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TimestampableEntity.php for compat with ORM v3 #2757

Closed

Conversation

andreybolonin
Copy link
Contributor

@andreybolonin andreybolonin commented Feb 8, 2024

@mbabker
Copy link
Contributor

mbabker commented Feb 8, 2024

This is an incorrect fix as it removes annotation support entirely. The presence of annotations when installed alongside ORM 3.0 in and of itself isn't an issue, unless, your application is still using annotations for something outside the ORM and this package's mapping and those annotations are being read by that process. In that case, you should add a call to Doctrine\Common\Annotations\AnnotationReader::addGlobalIgnoredNamespace('Doctrine\ORM\Mapping') so the annotation reader service in your application ignores the ORM's mapping classes.

As well, this package does not yet support ORM 3.0. You should downgrade your application to ORM 2.18 and continue using that until all dependencies are compatible with the new major release.

@mishac
Copy link

mishac commented Feb 9, 2024

In that case shouldn't the composer.json indicate the conflict with ORM > 2?

@mbabker
Copy link
Contributor

mbabker commented Feb 9, 2024

In that case shouldn't the composer.json indicate the conflict with ORM > 2?

Probably should've been done sooner, but #2759

@franmomu
Copy link
Collaborator

Closing as this is not right as explained in #2757 (comment)

@franmomu franmomu closed this Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants