Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove PHP 7.4 from allow_failures #3683

Closed
carusogabriel opened this issue Oct 1, 2019 · 2 comments
Closed

Remove PHP 7.4 from allow_failures #3683

carusogabriel opened this issue Oct 1, 2019 · 2 comments
Assignees
@morozov
Labels
CI Hacktoberfest Good issue for participating in Hacktoberfest
Milestone
2.9.3

Comments

@carusogabriel
Copy link
Contributor

PHP 7.4 will be released soon and we need to ensure that Doctrine is compatible with it.

All we need to do is to remove these following lines

dbal/.travis.yml

Lines 40 to 41 in b0726e7

allow_failures:
- php: 7.4snapshot

and verify that everything is working.

This is a very good issue for those who want to participate in https://hacktoberfest.digitalocean.com.
@carusogabriel carusogabriel added CI Hacktoberfest Good issue for participating in Hacktoberfest labels Oct 1, 2019
@joesaunderson joesaunderson mentioned this issue Oct 1, 2019
Closed
@morozov
Copy link
Member

morozov commented Oct 30, 2019

Fixed by #3702.

@morozov morozov closed this as completed Oct 30, 2019
@morozov morozov self-assigned this Oct 30, 2019
@morozov morozov modified the milestones: 2.10.0, 2.9.3 Oct 30, 2019
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@morozov morozov

Labels
CI Hacktoberfest Good issue for participating in Hacktoberfest
Projects
None yet
Milestone
2.9.3
Development

No branches or pull requests
2 participants
@morozov @carusogabriel