SQLSrv\LastInsertId::getId() is not used anywhere

[morozov]

Psalm level 2:

ERROR: MissingConstructor - lib/Doctrine/DBAL/Driver/SQLSrv/LastInsertId.php:13:13 - Doctrine\DBAL\Driver\SQLSrv\LastInsertId has an uninitialized property Doctrine\DBAL\Driver\SQLSrv\LastInsertId::$id, but no constructor (see https://psalm.dev/073)
    private $id;

Fixing this issue requires understanding how the value of $id is used by the consumers but it isn't. SQLSrv\Connection::lastInsertId() doesn't use it:

dbal/lib/Doctrine/DBAL/Driver/SQLSrv/SQLSrvConnection.php

Lines 143 to 157 in 493dc96

	public function lastInsertId($name = null)
	{
	if ($name !== null) {
	$stmt = $this->prepare('SELECT CONVERT(VARCHAR(MAX), current_value) FROM sys.sequences WHERE name = ?');
	$stmt->execute([$name]);
	} else {
	$stmt = $this->query('SELECT @@IDENTITY');
	}
	if ($stmt instanceof Result) {
	return $stmt->fetchOne();
	}
	return $stmt->fetchColumn();
	}

The class and all its usages are internal and can be safely removed in 3.1.0. Removing it in 2.12.x is undesired since not all class usages have been marked as such since 2.0.0.

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.