Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add backwards-compatible type declarations #8538

Closed
greg0ire opened this issue Mar 12, 2021 · 0 comments · Fixed by #8544
Closed

Add backwards-compatible type declarations #8538

greg0ire opened this issue Mar 12, 2021 · 0 comments · Fixed by #8544
Labels
Improvement

Comments

@greg0ire
Copy link
Member

We should grep for:

  • private function
  • final protected function
  • final class

And see if we can add type declarations.
Since the phpdoc might be inaccurate, this is a risky move, and as such should IMO target 2.9.x
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add type declarations where backwards-compatible greg0ire/doctrine-orm
1 participant
@greg0ire