Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PROTOTYPE ™ missing shadows and weak other graphical effects #4008

Closed
Mrblubb opened this issue May 18, 2024 · 21 comments · Fixed by #4011
Closed

PROTOTYPE ™ missing shadows and weak other graphical effects #4008

Mrblubb opened this issue May 18, 2024 · 21 comments · Fixed by #4011
Assignees
Labels

Comments

@Mrblubb
Copy link

Mrblubb commented May 18, 2024

When using dxvk shadows, bloom and other graphical effects are missing/weakened/not rendered correctly

Untitled-1
Untitled-2
Untitled-3
Untitled-4
Untitled-5
Untitled-6

Software information

PROTOTYPE PC Max settings with emoose patch

System information

  • GPU: GTX 1060 6GB stock
  • CPU: FX 8350 stock
  • Driver: 546.17
  • Windows: Win 10 x64
  • DXVK version: 2.3.1

Apitrace file(s)

https://we.tl/t-Bu8NKoCMzb

Log files

prototypef_d3d9.log

@K0bin K0bin added the d3d9 label May 18, 2024
@K0bin K0bin self-assigned this May 18, 2024
@K0bin
Copy link
Collaborator

K0bin commented May 18, 2024

@WinterSnowfall
Copy link
Contributor

WinterSnowfall commented May 18, 2024

@Mrblubb Out of curiosity, does dxgi.nvapiHack = False do anything for the missing shadows?

Edit: My bad, this is d3d9 game, so it wouldn't do anything anyway.

@Mrblubb
Copy link
Author

Mrblubb commented May 18, 2024

That happens on AMD cards and the fix provided in that makes shadows and some effects pixelated and not exactly accurate. With dxvk on nvidia it should render everything correctly

@K0bin
Copy link
Collaborator

K0bin commented May 18, 2024

image

Works fine when replaying the apitrace.

@Mrblubb
Copy link
Author

Mrblubb commented May 18, 2024

@Mrblubb Out of curiosity, does dxgi.nvapiHack = False do anything for the missing shadows?

didn't tried it I'll try
Edit: Tried enabling it but it's same. I think there's something else causing this.

@Mrblubb
Copy link
Author

Mrblubb commented May 18, 2024

@K0bin that's good! anyway it could render that way with only dxvk ?

@K0bin
Copy link
Collaborator

K0bin commented May 18, 2024

No, it's probably something that's baked into the apitrace.

@Mrblubb
Copy link
Author

Mrblubb commented May 18, 2024

Oh ok. Just tried with dgvoodoo and everything is rendered correctly there. But performance is not so good as dxvk

@Blisto91
Copy link
Contributor

Does it look correct if you create a file called dxvk.conf next to the games exe and insert d3d9.supportDFFormats = False

@Mrblubb
Copy link
Author

Mrblubb commented May 18, 2024

Does it look correct if you create a file called dxvk.conf next to the games exe and insert d3d9.supportDFFormats = False

I'll try.

@Mrblubb
Copy link
Author

Mrblubb commented May 18, 2024

OMG! Absolutely Fantastic. Shadows work perfectly now. Bloom as well. I'm not sure about smoke though, as it still looks better in native d3d9. But finally the game runs perfect locked 60fps without any dips. It's incredible on PC. Thanks a lot guys 😄
vlcsnap-2024-05-18-19h20m51s733
vlcsnap-2024-05-18-19h21m01s573
vlcsnap-2024-05-18-19h23m32s419
vlcsnap-2024-05-18-19h22m39s310
vlcsnap-2024-05-18-19h21m58s932
vlcsnap-2024-05-18-19h21m49s659
vlcsnap-2024-05-18-19h21m35s326
vlcsnap-2024-05-18-19h21m12s752

@Blisto91
Copy link
Contributor

Can you can get a couple of screenshots that better show the smoke difference between d3d9 and dxvk

@Mrblubb
Copy link
Author

Mrblubb commented May 18, 2024

Can you can get a couple of screenshots that better show the smoke difference between d3d9 and dxvk

Ok I'll make a good comparison.

@Mrblubb
Copy link
Author

Mrblubb commented May 18, 2024

Alright, its hard to get perfect one to one comparison given the scene is dynamic every time. So the density and transparency depends on it. I tried and got a close shot though
vlcsnap-2024-05-18-19h47m07s599
vlcsnap-2024-05-18-19h45m37s228

@Mrblubb
Copy link
Author

Mrblubb commented May 18, 2024

A video comparison.

Prototype.2024.05.18.-.19.38.04.02.online-video-cutter.com._2.mp4

D3d9

vlc.mp4

@Blisto91
Copy link
Contributor

I am not completely sure what i should look at as i am not sure i see a difference.
You could try to get a apitrace of just the smoke.

Or see if d3d9.floatEmulation = Strict makes a difference

@Mrblubb
Copy link
Author

Mrblubb commented May 18, 2024

Ok I'll try it & yeah it's pretty hard to notice sometimes. Smoke actually flickers when using mouse or pop-in pop-out or doesn't fade correctly. Hopefully this will fix it.

@K0bin
Copy link
Collaborator

K0bin commented May 18, 2024

I honestly don't see problem in the DXVK video clip.

@WinterSnowfall
Copy link
Contributor

WinterSnowfall commented May 18, 2024

@Mrblubb The shadows should work fine with Nvidia on latest master now (in line with native drivers), without having to mess with any config options. To fix this on AMD and potentially also Intel, we'd still need a config option for the game though. I'll leave that to @Blisto91, since he has the game.

@Mrblubb
Copy link
Author

Mrblubb commented May 18, 2024

Wonderful! Thanks a million @WinterSnowfall @K0bin @Blisto91 & everyone in the team. The game is looking and performing better than ever. And yeah about the smoke quality I played some scenarios multiple times and it seems smoke pop-in with mouse moving is vanilla issue so its fine for now, if only I could find any other perceivable difference further.
Cheers guys! 😁

@Blisto91
Copy link
Contributor

Thank you for a well made issue report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants