-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solution needed for deploying favicon.ico #210
Comments
@MarvDann I'm actually updating the documentation now, but if you put a |
Before I forget, you can of course reference |
README updates are now in |
@MarvDann Closing this since it seems to have been resolved. Please feel free to reopen if that's not the case. Thanks! |
Enhancement
At the moment when we build a dojo app we have to manually copy favicon.ico to the root of the website which isn't ideal in automated deployment scenarios and other methods need to be employed to copy the file.
A favicon.ico file needs to be present in the root of a website if you want to display a browser tab icon on all browsers. There are other methods which work in some browsers using meta tags to point to a file located elsewhere but this doesn't work consistently in Firefox and IE.
I think an improved solution would be to have the ability to define a shortcut_icon property in the .dojorc file which would copy the specified file into the root of the output build folder.
Alternatively we could automatically look for favicon.ico in the root of /src and copy that during the build process if it is present.
Package Version:
4.0.2
Code
Expected behavior:
Actual behavior:
The text was updated successfully, but these errors were encountered: