-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSS vs. POSTCSS sources #89
Comments
I have replied to this is
If you are able to set your code quality tools to avoid |
(Thx for the response and your suggestions, answers on Gitter.) Unfortunately we were coming from the other side - not CSS modules at all and we started with a predefined SCSS design. So we additionally used nesting (...) and other features in the I deeply respect your opinion on that - but we thought that it is meant to be Thx in advance. |
@szwoelf @lucidlemon in searching for an answer for this, could you tell us which CSS plugins for SonarQube you are using? Because nesting in PostCSS follows the CSS.Next syntax for nesting, we're wondering if the SonarQube CSS plugin should be fixed? What other features in .m.css is SonarQube complaining about from PostCSS? Also are you using any PostCSS features that are not part of CSS.Next? |
Also wondering if it's the plugin that is struggling with excludes, as I think SonarQube does support exclusions as per https://docs.sonarqube.org/display/SONAR/Narrowing+the+Focus . |
Thank you very much for the hint. I don't want to whine too much - but our version of SonarQube only supports a Anyway there is currently no PostCSS support in SonarQube. As you stated in our meeting ... "let's see what the future brings". |
@dylans the worst thing was the nesting syntax of PostCSS that broke the parser in SonarQube. This rendered the checks useless. In this case we couldn't even change the priority of some rule from whatever to 'minor'. |
Ok. The one thing worth noting is that it’s not PostCSS’ syntax, but rather the CSS Nesting specification syntax. So this means that SonarQube needs to get an update to support nesting. Are you locked on a particular version of SonarQube? I can reach out to their team and see if they have a fix planned for this. |
Closing this as I do not believe it to be relevant anymore |
We use different tools for testing code quality. Most of these tools use the file extension to determine the file type. Unfortunately the "*.m.css" files are post css files and sometimes the scanners fail.
Would it be possible to change the file extension of css to "pcss" so that IDEs, static code analysis tools (...) can recognize the file type by the extension?
(I hope that this issue is not completely wrong here - sorry if ...)
The text was updated successfully, but these errors were encountered: