This repository has been archived by the owner on Dec 12, 2018. It is now read-only.
Customizable Headers and Footers, fixes #11 #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #38 +/- ##
==========================================
+ Coverage 98.55% 98.69% +0.13%
==========================================
Files 12 13 +1
Lines 277 306 +29
Branches 49 55 +6
==========================================
+ Hits 273 302 +29
Partials 4 4
Continue to review full report at Codecov.
|
msssk
approved these changes
May 25, 2017
src/ColumnHeaders.ts
Outdated
| import { v, w } from '@dojo/widget-core/d'; | ||
| import { DNode } from '@dojo/widget-core/interfaces'; | ||
| import { RegistryMixin, RegistryMixinProperties } from '@dojo/widget-core/mixins/Registry'; | ||
| import { ThemeableMixin, theme, ThemeableProperties } from '@dojo/widget-core/mixins/Themeable'; |
kitsonk
suggested changes
May 26, 2017
src/Grid.ts
Outdated
| @@ -25,6 +27,8 @@ export const GridBase = ThemeableMixin(RegistryMixin(WidgetBase)); | |||
| export interface GridProperties extends ThemeableProperties, HasColumns { | |||
| registry?: GridRegistry; | |||
| dataProvider: DataProviderBase; | |||
| footers?: Array<HeaderType | DNode>; | |||
There was a problem hiding this comment.
generally we use (HeaderType | DNode)[]
src/Grid.ts
Outdated
| onSortRequest | ||
| }), | ||
| theme | ||
| }, <DNode[]> headers.map((child) => { |
There was a problem hiding this comment.
Seems odd we need a cast here. Also this logic is quite hard to follow in line and is duplicated below. This should probably be broken into a function that is easier to grok and maintain.
kitsonk
approved these changes
May 30, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: feature
The following has been addressed in the PR:
Description: