Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fuse_win: convert_flags() incorrectly sets O_RDWR/O_WRONLY #89

Closed
vmsrc opened this issue Oct 14, 2015 · 2 comments
Closed

fuse_win: convert_flags() incorrectly sets O_RDWR/O_WRONLY #89

vmsrc opened this issue Oct 14, 2015 · 2 comments

Comments

@vmsrc
Copy link
Contributor

vmsrc commented Oct 14, 2015

STANDARD_RIGHTS_WRITE and FILE_GENERIC_WRITE should not be part of ACCESS_WRITE.
The same applies to required_share().
STANDARD_RIGHTS_WRITE is "currently defined to READ_CONTROL" and is set for read operations.
FILE_GENERIC_WRITE contains STANDARD_RIGHTS_WRITE.
Thus, it's not currently possible to create read-only files with fuse_win.
@Liryna
Copy link
Member

Liryna commented Oct 14, 2015

Hi @c-klapaucius ,
I understand the issue with this flags and the ability to create read-only files.
Since I am not a user of dokan fuse, could you provide a pull request with the appropriate changes tested ?

@Liryna
Copy link
Member

Liryna commented Oct 15, 2015

Fixed with #90

@Liryna Liryna closed this as completed Oct 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Liryna @vmsrc