Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: 6.6.2 doesn't accept Assembly in the param in IncludeXmlComments #2935

Open
janzenz opened this issue Jun 6, 2024 · 6 comments
Open

Comments

@janzenz
Copy link

janzenz commented Jun 6, 2024

Describe the bug

According to the documentation here: https://github.com/domaindrivendev/Swashbuckle.AspNetCore?tab=readme-ov-file#include-descriptions-from-xml-comments

IncludeXmlComments should accept Assembly as a parameter but in the latest version 6.6.2 as of this writing isn't exposing this new method.

Expected behavior

IncludeXmlComments should accept Assembly as param as mentioned in the instructions.

Actual behavior

It doesn't accept Assembly and the IDE complains that this method doesn't have this override.

Steps to reproduce

Exception(s) (if any)

No response

Swashbuckle.AspNetCore version

6.6.2

.NET Version

8.0

Anything else?

No response

@janzenz janzenz added the bug label Jun 6, 2024
@martincostello
Copy link
Collaborator

martincostello commented Jun 6, 2024

@leotsarev Could you do a PR to tweak the README to note that this feature is available from v6.7.0 please?

Copy link
Contributor

github-actions bot commented Aug 6, 2024

This issue is stale because it has been open for 60 days with no activity. It will be automatically closed in 14 days if no further updates are made.

@github-actions github-actions bot added the stale Stale issues or pull requests label Aug 6, 2024
@leotsarev
Copy link
Contributor

I'm sorry for inconvenience. Missed bug. I think now that 6.7 have been released, it's no point to add this information.

@martincostello
Copy link
Collaborator

Is it fixed in 6.7.0? If not, the information is still useful.

@leotsarev
Copy link
Contributor

The problem is that README recommends method that was added only in 6.7.0

@martincostello
Copy link
Collaborator

That's not a problem - 6.7.0 is the latest released version and that's what we recommend people use.

If 6.7.0 resolved the ask, we can close this issue. If it didn't, then we need more information to action it.

@github-actions github-actions bot removed the stale Stale issues or pull requests label Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants